chore: rename tests/ to fixtures/ at repo root#1619
Closed
kitsuyui wants to merge 1 commit into
Closed
Conversation
Code Metrics Report
Details | | main (29b12fb) | #1619 (73c7869) | +/- |
|---------------------|----------------|-----------------|------|
| Coverage | 87.2% | 87.2% | 0.0% |
| Files | 11 | 11 | 0 |
| Lines | 141 | 141 | 0 |
| Covered | 123 | 123 | 0 |
| Code to Test Ratio | 1:0.5 | 1:0.5 | 0.0 |
| Code | 1146 | 1146 | 0 |
| Test | 641 | 641 | 0 |
+ | Test Execution Time | 6s | 5s | -1s |Reported by octocov |
The tests/ directory contained only static fixture files (HTML, images), not test code. All spec files live under src/ and were already co-located with the source they test. Rename tests/fixtures/ → fixtures/ to match the directory's actual purpose. Update all references in src/render/index.spec.ts and biome.json.
kitsuyui
force-pushed
the
fix/audit-test-fixtures-misnamed-root-001
branch
from
June 4, 2026 15:54
10d4bf6 to
2974951
Compare
gh-counterPR gate
Repo dashboard
Reported by gh-counter |
Owner
Author
|
Closing this stale structure-only rename because it now conflicts with current main and is not tied to a current maintenance need. If the layout still causes a concrete problem, it should be reconsidered from current main with fresh evidence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
tests/directory contained only static fixture files (HTML pages and images), not test code. All spec files are already co-located undersrc/alongside the source they test.Rename
tests/fixtures/→fixtures/at the repo root so the directory name matches its actual content.Changes
tests/fixtures/{html,images,react,vue}→fixtures/{html,images,react,vue}(8 files)src/render/index.spec.ts:tests/fixtures/*→fixtures/*biome.json:!tests/fixtures/react/index.html→!fixtures/react/index.htmlVerification
bun run lint(Biome): 30 files checked, no issuesbun run test: 9 test files, 35 tests — all passedtsc --noEmit: 0 type errors