refactor: dedup TranslateFn helpers and controllable-open into @multica/core - #4
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
refactor: dedup TranslateFn helpers and controllable-open into @multica/core#4devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…into @multica/core Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jscpdflagged two patterns duplicated across theviewspackage. Both are extracted into@multica/coreand adopted at every call site — no behavior change.1. The
ttranslate-prop pattern (~27 files). Each view component redeclared the same type and fallback logic:Now provided once in
packages/core/hooks/useTranslation.ts:Call sites collapse to
import { withT, fallbackT, type TranslateFn } from "@multica/core"and eitherconst translate = withT(t)or at = fallbackTdefault param.2. Controlled/uncontrolled open state (3 pickers).
assignee/priority/statuspickers each had:Replaced by a new
useControllableOpen(controlledOpen, controlledOnOpenChange)hook inpackages/core/hooks/use-controllable-open.tsreturning[open, setOpen].Notes
useControllableOpen,withT,fallbackTand theTranslateFntype are re-exported from the@multica/corebarrel.issues-page.test.tsx's@multica/coremock gains the new exports (withT,fallbackT,useControllableOpen) since the components under test now consume them.pnpm typecheckclean on changed files,pnpm testfor core passes, views test suite unchanged vs. base (the 7issue-detail.testfailures —api.getIssueWorkdirFiles is not a function— and the captcha typecheck/lint errors are pre-existing onmain).Link to Devin session: https://app.devin.ai/sessions/036672cd408042b191cb2beeb5405f75
Requested by: @killerleon94