ci: ai-code-review: preserve ci/ across the source move - #498
Open
theihor wants to merge 1 commit into
Open
Conversation
The AI review config (ci/claude/) lives on every *_base branch, so it is present in the pull_request checkout that actions/checkout uses by default (the merge ref, head merged into base). But "Move linux source in place" ran `rm -rf .git .github ci` and then overlaid the PR *head* tree fetched separately by get-linux-source (head.sha only, not the merge). Series whose head does not carry ci/ -- built on a base without the injection, or manual branches -- thus lost the config, and the claude-code-action step failed with: Error: Invalid MCP configuration: MCP config file not found: .../ci/claude/mcp.json The same post-move loss would break ci/claude/post-pr-comment.js, which the "Comment on PR" step requires later. Keep the checked-out ci/ across the move (drop only the head tree's own ci/ to avoid a collision) so the config is available regardless of whether the head carries it. No config duplication or inlining needed; ci/claude/*.json stays the single source of truth, consistent with ai-agent.yml, whose move does not delete ci/ and was never affected. Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AI review config (ci/claude/) lives on every *_base branch, so it is present in the pull_request checkout that actions/checkout uses by default (the merge ref, head merged into base). But "Move linux source in place" ran
rm -rf .git .github ciand then overlaid the PR head tree fetched separately by get-linux-source (head.sha only, not the merge). Series whose head does not carry ci/ -- built on a base without the injection, or manual branches -- thus lost the config, and the claude-code-action step failed with:Error: Invalid MCP configuration:
MCP config file not found: .../ci/claude/mcp.json
The same post-move loss would break ci/claude/post-pr-comment.js, which the "Comment on PR" step requires later.
Keep the checked-out ci/ across the move (drop only the head tree's own ci/ to avoid a collision) so the config is available regardless of whether the head carries it. No config duplication or inlining needed; ci/claude/*.json stays the single source of truth, consistent with ai-agent.yml, whose move does not delete ci/ and was never affected.