Skip to content

Fix ORC managed log collection#856

Open
winiciusallan wants to merge 3 commits into
k-orc:mainfrom
winiciusallan:kuttl-skip-delete
Open

Fix ORC managed log collection#856
winiciusallan wants to merge 3 commits into
k-orc:mainfrom
winiciusallan:kuttl-skip-delete

Conversation

@winiciusallan

Copy link
Copy Markdown
Member

When a failure in the CI occurs, the collectlogs script is not properly collecting logs for two reasons:

  1. It is not using the FQDN name for the resources, which causes the script to collect the Kubernetes service resource, instead of the Openstack service managed by ORC
  2. After the completion of kuttl test, it deletes all of the resources, preventing the script which runs afterwards to collect the managed resources.

This PR add the KUTTL_SKIP_DELETE flag to prevent kuttl of deleting the resources and use FQDN resource names.

Closes #855

@github-actions github-actions Bot added the semver:patch No API change label Jul 17, 2026

@dlaw4608 dlaw4608 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Both fixes are correct:

  1. FQDN resource names in collectlogs properly disambiguates ORC resources from Kubernetes built-ins.
  2. --skip-delete ensures test resources survive for log collection on failure.

The --skip-delete is set unconditionally (even on passing tests), but this is harmless since the kind cluster is torn down at the end of the job regardless. Worth revisiting only if make test-examples starts colliding with leftover resources from make test-e2e.

E2E tests failing due to Router and Subnet timeouts, unrelated to the changes in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch No API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The CI is not properly collecting logs in failures

2 participants