Fix potential race in interface/volume status update#843
Open
mandre wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Aha, this doesn't work because now we're clearing the other fields. We need to use a different field owner. I'll just keep the second commit. |
mandre
force-pushed
the
fix-attachment-race
branch
from
July 8, 2026 08:39
c16f12b to
de22e4c
Compare
After a port is attached to a server, its Neutron status transitions
asynchronously from DOWN to ACTIVE. Similarly, a volume transitions
from available to in-use after attachment. The cross-controller
signaling via serverTo{Port,Volume}MapFunc is susceptible to a race
with the controller's own status write.
Add defense-in-depth polling: when the port has a device_id but
status is still DOWN, or when a volume has attachments but status
is not in-use, schedule a re-fetch via WaitingOnOpenStack. This
ensures the controller picks up the status transition regardless
of whether the cross-controller signal is lost.
Fixes k-orc#842
mandre
force-pushed
the
fix-attachment-race
branch
from
July 8, 2026 08:55
de22e4c to
d9ce2e3
Compare
| // overwrite Progressing=True with Progressing=False before the | ||
| // port becomes ACTIVE. Poll here so we keep Progressing=True | ||
| // until the transition completes. | ||
| if osResource.Status == PortStatusDown { |
Member
There was a problem hiding this comment.
The controller can exit from the previous for loop without finding a match server which the port is attached to, so this will not catch the case where port is attached and is DOWN.
Maybe adding a found = true to ensure that we don't make unnecessary API calls to OpenStack?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a port is attached to a server, its Neutron status transitions
asynchronously from DOWN to ACTIVE. Similarly, a volume transitions
from available to in-use after attachment. The cross-controller
signaling via serverTo{Port,Volume}MapFunc is susceptible to a race
with the controller's own status write.
Add defense-in-depth polling: when the port has a device_id but
status is still DOWN, or when a volume has attachments but status
is not in-use, schedule a re-fetch via WaitingOnOpenStack. This
ensures the controller picks up the status transition regardless
of whether the cross-controller signal is lost.
Fixes #842