Adopt sys::expected for the hidraw ioctl chain - #26
Merged
Conversation
Extend the std::expected error-model adoption to ioctl. Add a sys::ioctl wrapper returning std::expected<int, std::error_code> and convert the hidraw setup chain (HIDIOCGRAWINFO/NAME/PHYS/RDESCSIZE/RDESC) in all three controllers and the ps5 HIDIOCGFEATURE feature reads. Each failed ioctl now logs the specific errno message (e.g. "HIDIOCGRAWINFO failed: No such device") instead of a bare tag, and the reused `int res` pattern becomes per-call scoped checks. sys_test gains an ioctl case (a terminal ioctl on a non-tty fd -> ENOTTY). Signed-off-by: Joel Winarske <joel.winarske@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt sys::expected for the hidraw ioctl chain
Extend the std::expected error-model adoption to ioctl. Add a sys::ioctl
wrapper returning std::expected<int, std::error_code> and convert the hidraw setup chain (HIDIOCGRAWINFO/NAME/PHYS/RDESCSIZE/RDESC) in all three controllers and the ps5 HIDIOCGFEATURE feature reads.
Each failed ioctl now logs the specific errno message (e.g. "HIDIOCGRAWINFO failed: No such device") instead of a bare tag, and the reused
int respattern becomes per-call scoped checks. sys_test gains an ioctl case (a terminal ioctl on a non-tty fd -> ENOTTY).