Preserve Slack harness context for live connector grounding - #51
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe durable runtime now shares persisted-request parsing through an exported Zod-backed helper that supports harness modes. Integration tests validate Slack harness preservation and connector evidence loading through a local HTTP connector and durable run. ChangesRuntime harness support
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
slack, in the agent gateway.Root cause
The gateway's persisted-request Zod schema omitted
harness. Zod stripped{ harness: { mode: "slack" } }before live connector evidence loading. Slack transport and delivery succeeded, but Jessie received no Tawny, Kelpie, or UniFi evidence and produced ungrounded no-data replies.Impact
Slack agent runs can now load governed live connector context without weakening organisation, capability, credential, or query-template controls.
Validation
pnpm --dir apps/agent-gateway typecheckpnpm --dir apps/agent-gateway test -- src/runtime.integration.test.ts— 5 passed, 15 opt-in integration tests skipped without the database environmentgit diff --checkA live Yarn Digi Slack smoke will be run after homelab deployment.
Summary by CodeRabbit
New Features
Bug Fixes