Skip to content

Reject comment records from @CsvSource.value#5886

Open
mpkorstanje wants to merge 4 commits into
mainfrom
rien/reject-comments-from-csvsource-value
Open

Reject comment records from @CsvSource.value#5886
mpkorstanje wants to merge 4 commits into
mainfrom
rien/reject-comments-from-csvsource-value

Conversation

@mpkorstanje

@mpkorstanje mpkorstanje commented Jul 19, 2026

Copy link
Copy Markdown
Member

We want to deprecate @CsvSource.textBlock in favour of .value[] (#5887).

Functionally value[] and textBlock are not identical. textBlock skips comment lines while value[] treats these as regular records. To make them identical, comment lines in value[] should be skipped too in v7. To ensure that enabling skipping comment lines does not result in lost test cases from value[] we preemptively reject comment lines in v6. That way when wen upgrading a passing suite from the latest v6.x to v7 there will be no comment lines in value[] making the upgrade safe.

Consequently, this also means that delimiter, quoteCharacter and commentCharacter must be distinct for both textBlock and value[].

Contributes to: #5017


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@mpkorstanje
mpkorstanje force-pushed the rien/reject-comments-from-csvsource-value branch from d0cda35 to c42d7ac Compare July 19, 2026 16:20
@mpkorstanje
mpkorstanje marked this pull request as ready for review July 19, 2026 16:28
@mpkorstanje mpkorstanje added this to the 6.2.0-M1 milestone Jul 19, 2026
@mpkorstanje
mpkorstanje requested a review from marcphilipp July 19, 2026 16:33
@mpkorstanje mpkorstanje changed the title Reject comments from @CsvSource.value Reject comment records from @CsvSource.value Jul 19, 2026
@testlens-app

testlens-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: cc1fbe3
▶️ Tests: 4515 executed
⚪️ Checks: 18/18 completed


Learn more about TestLens at testlens.app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant