Reject comment records from @CsvSource.value#5886
Open
mpkorstanje wants to merge 4 commits into
Open
Conversation
This was referenced Jul 19, 2026
mpkorstanje
force-pushed
the
rien/reject-comments-from-csvsource-value
branch
from
July 19, 2026 16:20
d0cda35 to
c42d7ac
Compare
mpkorstanje
marked this pull request as ready for review
July 19, 2026 16:28
✅ All tests passed ✅🏷️ Commit: cc1fbe3 Learn more about TestLens at testlens.app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to deprecate
@CsvSource.textBlockin favour of.value[](#5887).Functionally
value[]andtextBlockare not identical.textBlockskips comment lines whilevalue[]treats these as regular records. To make them identical, comment lines invalue[]should be skipped too in v7. To ensure that enabling skipping comment lines does not result in lost test cases fromvalue[]we preemptively reject comment lines in v6. That way when wen upgrading a passing suite from the latest v6.x to v7 there will be no comment lines invalue[]making the upgrade safe.Consequently, this also means that
delimiter,quoteCharacterandcommentCharactermust be distinct for bothtextBlockandvalue[].Contributes to: #5017
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations