Skip to content

fix(homepage): prevent "Open Community Working Meetings" button text overflow on mobile/ipad - #2437

Merged
vtushar06 merged 2 commits into
json-schema-org:mainfrom
ikshantshukla123:fix/meetings-button-mobile-overflow
Jul 13, 2026
Merged

fix(homepage): prevent "Open Community Working Meetings" button text overflow on mobile/ipad#2437
vtushar06 merged 2 commits into
json-schema-org:mainfrom
ikshantshukla123:fix/meetings-button-mobile-overflow

Conversation

@ikshantshukla123

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Bugfix (CSS-only, one line)

Issue Number:

Screenshots/videos:
Before:
Screenshot 2026-07-12 at 12 14 47 PM

After:
Screenshot 2026-07-12 at 12 13 50 PM

Before:
Screenshot 2026-07-12 at 12 15 54 PM

After:
Screenshot 2026-07-12 at 12 16 22 PM

If relevant, did you update the documentation?

Not applicable — no documentation changes needed.

Summary

On mobile viewports, the "Open Community Working Meetings" button on the
homepage broke: its label wrapped to two lines, overflowing the fixed
h-[40px] height, and with no horizontal padding the text touched the
button borders.

This PR sizes the button by its content instead of hardcoding dimensions:

  • h-[40px]min-h-[40px] — desktop still renders at exactly 40px,
    but the button can grow when the label wraps
  • added px-4 py-2 — the text keeps breathing room at every width
  • max-w-[300px] w-fullw-fit max-w-full — the button shrink-wraps
    to its label plus padding (the same sizing model already used by the
    equivalent button on the Community page, which does not have this bug)

The sibling "Office Hours" button is unaffected (its short label never
wraps), so it was intentionally left untouched to keep the diff minimal.

All Cypress specs pass (yarn cypress:run:all, 294/294).

Does this PR introduce a breaking change?

No.

Checklist

The 'Open Community Working Meetings' button used a fixed h-[40px]
with no horizontal padding, so on narrow viewports the wrapped label
overflowed the button and touched its borders. Size the button by its
content instead (w-fit, min-h-[40px], px-4 py-2) so it renders
identically on desktop and grows gracefully when the text wraps.

Fixes json-schema-org#2436
@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 2ec6756

@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (07e6bc8) to head (2ec6756).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2437   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          695       695           
  Branches       215       215           
=========================================
  Hits           695       695           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vtushar06 vtushar06 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, one thing I would like to mention can you please wait until a issues passes triage, and there is one more fix switch to iphone 12 and see text on hero page it is there on boundary so please correct that.

And rest done from my side.

On small viewports (e.g. iPhone 12, 390px) the hero subtitle text
touched the viewport edges. Add px-4 on mobile only; md+ unchanged.
@ikshantshukla123

Copy link
Copy Markdown
Contributor Author

Thanks for the fix, one thing I would like to mention can you please wait until a issues passes triage, and there is one more fix switch to iphone 12 and see text on hero page it is there on boundary so please correct that.

And rest done from my side.

Thanks for the review! Both points addressed:

Understood on triage I'll wait for issues
to pass triage before opening PRs going forward.
Fixed in 2ec6756 the hero subtitle h2 had no horizontal padding, so its text touched the viewport edges on small screens. Added px-4 md:px-0 (mobile-only, desktop unchanged). Verified on iPhone 12 (390px).

Screenshot 2026-07-13 at 3 28 46 PM

@vtushar06 vtushar06 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 @ikshantshukla123, Thanks

@vtushar06
vtushar06 merged commit 6116dd3 into json-schema-org:main Jul 13, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to review to Done in PR - Triage Group Jul 13, 2026
@github-actions

Copy link
Copy Markdown

Congratulations, @ikshantshukla123 for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛 Bug: "Open Community Working Meetings" button text overflows and touches edges on mobile/ipad view

2 participants