Visual redesign: new hero/nav/footer, PicoCSS styling, refreshed copy#63
Open
johngallagher wants to merge 1 commit into
Open
Visual redesign: new hero/nav/footer, PicoCSS styling, refreshed copy#63johngallagher wants to merge 1 commit into
johngallagher wants to merge 1 commit into
Conversation
Ports a community-built visual redesign (prototyped at github.com/johngallagher/diamond) onto the existing site structure. - Vendors PicoCSS classless + a new style.css, replacing main.css/ carousel.css/ie7-hacks.css and the Typekit font loader. - Restyles menu/banner/release/footer includes and the main/home/post layouts; all existing nav destinations, the release widget, the Recent News/Recent Toots (Mastodon)/Awards/Engine Yard sections on the homepage, and Google Analytics tracking are preserved, just restyled. - Refreshes prose on getting-started, documentation, community, contribute, security, and blogs. Left nightly/chat untouched since their existing copy is more current than the prototype's. - download.html and _config.yml are untouched apart from added CSS wrapper divs around each release block -- the exact version/URL text that rakelib/release.rake's change_versions_in substitutes on every release is preserved byte-for-byte (verified by diff). - Adds an authorized Headius Enterprises support banner/footer link (coordinated directly with the Headius team). - Leaves old stylesheets/, javascripts/, and images/ in place unreferenced rather than deleting them, since some images are embedded in historical posts and external links may target them. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a proposal to refresh the look of jruby.org, prototyped first at johngallagher/diamond and ported here. Per the README's note to consult before large changes, I'd like this to be a starting point for discussion rather than something to merge as-is -- happy to iterate or narrow scope based on feedback.
stylesheets/style.css. Removes the oldmain.css/carousel.css/ie7-hacks.cssand the Typekit font loader (left on disk, just unreferenced).getting-started,documentation,community,contribute,security, andblogs. I deliberately leftnightlyandchatuntouched -- their current copy (Sonatype Central links, Matrix logs, IRC bridge) is already more accurate/current than what the prototype had, so replacing it would have been a regression./twitterstays linked from somewhere (the prototype had dropped it).What's deliberately unchanged
rakelib/release.rake'schange_versions_indoes plain text substitution of version strings indownload.htmland_config.ymlon every release. I restyleddownload.htmlby wrapping each release block in a<div class="release-card">only -- diffed against master to confirm every version string, URL, and bit of release text is byte-for-byte identical otherwise._config.ymlis untouched entirely.site.webmanifest,browserconfig.xml, and the existing favicon/touch-icon images are untouched._includes/tracking.html) is still included on every page in the same position._posts/,Rakefile,cookbooks/,conf/,config.ru,patches/,templates/,files/,apidocs/,CNAME,.htaccess,robots.txt,atom.xml,Gemfile-- none of these were touched.stylesheets/,javascripts/, andimages/are left on disk even where now unreferenced, rather than deleted -- a couple of old posts embed images directly (e.g.jruby-bug-chart-jan-2010.png), and there may be external hotlinks I can't see. Happy to clean these up in a follow-up if maintainers prefer.One thing to flag explicitly
The footer now includes a "Professional Support" link to Headius Enterprises. This was coordinated directly with the Headius team beforehand -- flagging it here so it's not a surprise in review.
Test plan
bundle exec jekyll buildsucceeds with no new warnings (the pre-existingLayout 'nil' requested in atom.xmlwarning is present on master too)download.htmland_config.ymlagainstmasterto confirm only CSS wrapper divs were added around release blocks, no text/URL changesindex.html,download.html,news.html, a_postsentry,security.markdown, and404.html-- nav links resolve, the release widget shows livesite.releasedata, and the homepage's Mastodon/awards/Engine Yard sections still renderrake deploy/rake serverflow, since I could only verify viajekyll buildlocally🤖 Generated with Claude Code