Clock-safe dwell and richer diagram motion - #68
Merged
Conversation
Add a dwell slot to the reveal timeline so long subject-beat holds can play Indicate/Circumscribe without racing the next wait_word. Boxes may declare shape, reveal, and emphasis; edges compile as mobject-to-mobject connectors instead of center-to-center points. Co-authored-by: jmjava <jmjava@gmail.com>
…lary Upgrade _box (pill/diamond) and _arrow (edge-to-edge, still accepts legacy points). scene-compile refreshes stale helper bodies in scenes.py without touching generated classes. The scene-spec LLM prompt and dogfood hint now describe shape, reveal, emphasis, and clock-safe dwell. Co-authored-by: jmjava <jmjava@gmail.com>
Add scene_assets so we fail before Manim when a spec would dump-and-freeze, overflow the frame, use a machine-default Pango font, or when scenes.py is stale vs compile. generate-all runs the same check as a preflight. Compiled Text() now sets font=MANIM_FONT; helpers refresh if that constant is missing. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
August 15, 2026 03:18
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Diagram timing was already fail-closed (
wait_word, FadeIn clamp, issue #66), but compiled boards still looked thin: rounded boxes, center-to-center arrows, and a freeze during the long holds that subject-beat coverage wants. Adding raw Manim animations without a dwell slot would race_clockagain.We have also burned renders on stuck boards, overlapping stacks, and Pango font drift. Those need to fail before
docgen manim, not after a long compose.What
Motion base
simulate_reveal_timeline: after each reveal, if the gap to the nextwait_wordis long enough, allocate a clampedIndicate(pulse) orCircumscribe(ring). Tight cascades still get zero dwell.shape(rounded|pill|diamond),reveal(fade|grow|slide),emphasis(none|pulse|ring).layout.dwell_emphasis: auto|noneandlayout.dwell_run_time._arrow(...)(edge-to-edge). Legacy.get_center()calls still work.refresh_bootstrap_helpers:scene-compilerewrites stale_box/_arrow/_TimedScenebodies when they lackshape,get_critical_point,not_past, orMANIM_FONT. Generated scene classes are left alone.scene-spec-generatecan use them without inventing labels.Pre-render validation (
scene_assets)New check in
docgen validate(hard fail in--pre-push) and agenerate-allgate before Manim:reveal_cadence_violations+ dwell-overshoot (fade+dwell cannot pass the nextwait_word)layout_budget_violationson the spec (frame stack / row width)Text()setsfont=MANIM_FONT; lint fails iffont=is missing;_boxsubtitles no longer drop below 14scenes.pymotion plan must match a freshcompile_scene_class(missing Indicate, center-arrows, absent class → fail withscene-compile --retime)_box/_arrow/_TimedScene/ missingMANIM_FONTDisable with
validation.scene_assets.enabled: falseif needed.Consumers pick this up by bumping the docgen pin and re-running
scene-spec-generate/scene-compile --retime. No hand-edits of generated YAML or marker blocks.Tests
tests/test_scene_motion.py— dwell math, tight vs wide holds, compile emissiontests/test_scene_asset_validate.py— overshoot, motion plan, helper API, compile sync, layout-as-overlap, pre-push hard fail, pipeline-facing bundle preflightfont=lint casesruff check src/ tests/clean;pytest tests/377 passed.