Skip to content

Do not write stack trace to system log for unauthorized API access #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarkEWaite wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not write stack trace to system log for unauthorized API access #340

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59021b7
Do not write stack trace to system log for unauthorized API access
MarkEWaite Jul 10, 2026
83dee35
Guard the logging call to avoid work when not logging
MarkEWaite Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/main/java/net/uaznia/lukanus/hudson/plugins/gitparameter/GitParameterDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,17 @@
if (job == null) {
return ItemsErrorModel.EMPTY;
}
job.checkPermission(Job.BUILD);
try {
job.checkPermission(Job.BUILD);
} catch (org.springframework.security.access.AccessDeniedException e) {
// Write the exception to the logger, not to the Jenkins log.
//
// https://github.com/jenkinsci/git-parameter-plugin/issues/339
if (LOGGER.isLoggable(Level.FINE)) {
LOGGER.log(Level.FINE, job.getDisplayName() + " " + e.getMessage(), e);
}
return ItemsErrorModel.EMPTY;

Check warning on line 743 in src/main/java/net/uaznia/lukanus/hudson/plugins/gitparameter/GitParameterDefinition.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered lines 

Lines 736-743 are not covered by tests
}

JobWrapper jobWrapper = JobWrapperFactory.createJobWrapper(job);

Expand Down