ci(apps): run format:check on whole repo for PR/main parity#40
Open
jdwillmsen wants to merge 3 commits into
Open
ci(apps): run format:check on whole repo for PR/main parity#40jdwillmsen wants to merge 3 commits into
jdwillmsen wants to merge 3 commits into
Conversation
These files predate the format:check --all gate and were never re-checked under affected-only scoping, so they drifted out of prettier compliance on main. Reformat them so the whole-repo gate passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Assisted-by: Claude:Opus-4.8
LICENSE.md is verbatim third-party license text (PolyForm). Prettier would rewrite its whitespace and emphasis markers; exclude it so format:check --all does not flag or mutate canonical legal text. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Assisted-by: Claude:Opus-4.8
nx format:check defaults to affected scope, so its coverage tracks git context (PR diff on pull_request, push range on main). A formatting violation in a file the change does not touch passes the PR gate but fails the main-push gate — a green PR did not imply a green main (JDWLABS-63). Add --all so the format gate checks the entire repo on every event. Formatting is a whole-repo invariant, not a per-project task; unlike lint/test/ build (kept on nx affected for cache/time), format:check over the repo is sub-second, so there is no reason to scope it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Assisted-by: Claude:Opus-4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (JDWLABS-63)
nx format:checkdefaults to affected scope, so the format gate's coverage tracks git context — the PR diff onpull_request, the push range onmain-push. A repo-wide formatting violation in a file the change doesn't touch therefore passes every PR yet fails on main-push: a green PR did not imply a greenmain.Verified locally: with an empty affected range,
nx format:checkexits 0 whilenx format:check --allexits 1 and flags the offenders.Change
ci.yml:nx format:check→nx format:check --all. The gate now checks the entire repo on every event, so a green PR guarantees a greenmainfor formatting. lint/test/build stay onnx affected(expensive, cacheable, project-scoped); whole-repo format is sub-second, so there's no reason to scope it.--allis green..prettierignore: addedLICENSE.md— canonical third-party license text that prettier would otherwise rewrite.Verification
pnpm exec nx format:check --all→ exit 0 on this branch.Follow-up (not in this PR)
The ticket's second bullet — requiring the format status check in branch protection so an admin override isn't the path of least resistance — is a GitHub ruleset change, tracked separately (org governance, JDWLABS-14).
🤖 Generated with Claude Code