Conversation
jbcoe
marked this pull request as ready for review
July 22, 2026 22:18
Collaborator
|
I think these are great, first 2 down and working through the 3rd now, but these are definitely useful (I'm learning reflection from the 3rd). Perhaps the files could be renamed with a number indicating the order of the tutorials?
The pedant in me finds it odd to start in the middle, go down and then go up in the file view in VSCode. |
Twon
reviewed
Jul 23, 2026
| int z = 0; | ||
| }; | ||
|
|
||
| consteval std::vector<std::meta::info> data_members_of(std::meta::info type) { |
Collaborator
There was a problem hiding this comment.
May as well just use std::vector's range constructor
Suggested change
| consteval std::vector<std::meta::info> data_members_of(std::meta::info type) { | |
| consteval std::vector<std::meta::info> data_members_of(std::meta::info type) { | |
| return std::meta::nonstatic_data_members_of( | |
| type, std::meta::access_context::current()); | |
| } |
Twon
reviewed
Jul 23, 2026
| int payload = 0; | ||
| }; | ||
|
|
||
| consteval std::vector<std::meta::info> member_functions_of( |
Collaborator
There was a problem hiding this comment.
consteval std::vector<std::meta::info> member_functions_of(std::meta::info type) {
// is_function alone would also match Widget's implicit special
// members (default constructor, destructor, ...);
// is_special_member_function excludes those, leaving just the
// two ordinary methods below.
auto const is_member_function = [](std::meta::info member) {
return std::meta::is_function(member) && !std::meta::is_special_member_function(member);
};
return std::meta::members_of(type, std::meta::access_context::current()) |
std::ranges::views::filter(is_member_function) |
std::ranges::to<std::vector<std::meta::info>>();
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure that these tutorials are necessary.
The act of writing them was useful and perhaps they will be useful to readers of the (increasingly novel and technical) code in #95.