Make browser state refs read-only - #2295
Draft
ruohuaqian wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make normal browser state snapshots read-only for page DOM.
browser statestill emits stable[N]refs, but stores the live element map inwindow.__opencli_ref_elementsinstead of writingdata-opencli-refattributes onto business DOM nodes. The target resolver now prefers that in-memory map and keeps legacydata-opencli-reflookup as a compatibility fallback.Annotated screenshots still opt into DOM annotation because the visual overlay currently relies on those attributes.
Root Cause
Some sites monitor unexpected DOM attribute mutations. The previous DOM snapshot path wrote
data-opencli-refattributes during ordinary state reads, which could trigger page-side integrity logic and cause repeated refreshes or redirects.Validation
npx vitest run --project unit src/browser/dom-snapshot.test.ts src/browser/target-resolver.test.ts src/browser/base-page.test.tsnpm run typechecknpm run buildhttps://www.zhipin.com/web/geek/jobs:opencli browser zhipinfix statereturned the page state, anddocument.querySelectorAll('[data-opencli-ref]').lengthreturned0after the state read.