Skip to content

fix(install): reject option-like skill names - #2

Open
itsjling wants to merge 2 commits into
mainfrom
advisor/001-reject-option-like-skill-names
Open

fix(install): reject option-like skill names#2
itsjling wants to merge 2 commits into
mainfrom
advisor/001-reject-option-like-skill-names

Conversation

@itsjling

Copy link
Copy Markdown
Owner

What changed

  • reject dash-prefixed skill names from discovery output
  • reject unsafe names in catalog validation without echoing the raw value
  • guard direct install calls before logging or invoking the upstream runner
  • keep multiword skill names unchanged
  • add regression tests for all three boundaries
  • mark Plan 001 done

Why

skills@1.5.22 treats a dash-prefixed value after --skill as an option. A source or hand-edited catalog could therefore alter the install command instead of naming a skill.

Impact

Unsafe names now fail before they reach the upstream command parser. Existing normal names, including multiword names, keep their exact argument form.

Checks

  • pnpm install --frozen-lockfile
  • pnpm typecheck
  • pnpm exec vitest run test/viblib.test.ts -t "option-like" — 4 passed
  • pnpm test — 23 passed
  • pnpm check
  • git diff --check origin/main..HEAD

Replaces #1, which only marked the plan as done.

@itsjling
itsjling marked this pull request as ready for review August 14, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant