fix(install): reject option-like skill names - #2
Open
itsjling wants to merge 2 commits into
Open
Conversation
itsjling
marked this pull request as ready for review
August 14, 2026 10:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
skills@1.5.22treats a dash-prefixed value after--skillas an option. A source or hand-edited catalog could therefore alter the install command instead of naming a skill.Impact
Unsafe names now fail before they reach the upstream command parser. Existing normal names, including multiword names, keep their exact argument form.
Checks
pnpm install --frozen-lockfilepnpm typecheckpnpm exec vitest run test/viblib.test.ts -t "option-like"— 4 passedpnpm test— 23 passedpnpm checkgit diff --check origin/main..HEADReplaces #1, which only marked the plan as done.