Resolve rawdata word type from GO_raw_data_format/ACQ_word_size + BYTORDA (no version gate)#39
Merged
headmeister merged 1 commit intoJul 22, 2026
Conversation
The PV-360 rawdata numpy_dtype only resolved for ACQ_word_size=_32_BIT with BYTORDA=little. ParaVision's ACQ_word_size also allows _16_BIT (D02 PvParams), and BYTORDA may be big; those combinations previously matched no branch and failed with MissingProperty. Add the int16 and big-endian variants next to the existing int32/little entry, keeping the same ACQ_sw_version gate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gdevenyi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Resolve the
rawdataword type purely fromGO_raw_data_format/ACQ_word_size+BYTORDA, with noACQ_sw_versiongate.Previously
numpy_dtyperequiredACQ_sw_versionto be in a hardcoded whitelist (a<PV 5.1>/<PV 6.0>/<PV 6.0.1>/<PV-7.0.0>list for theGO_*branches, a PV-360 list for theACQ_word_sizebranch), and theACQ_word_size(job-based / PV360) path only covered_32_BITlittle-endian. The raw word type is fully determined by the word-format and byte-order parameters and does not depend on the ParaVision version, so those version conditions were both redundant and a source ofMissingPropertyfailures on any unlisted version.This reframes the original "add PV360 16-bit/big-endian branches" change following the discussion in #41 (thanks @headmeister).
Change
ACQ_sw_versioncondition from everynumpy_dtypebranch.ACQ_word_sizefallback — adds_32_BIT/big,_16_BIT/little,_16_BIT/big alongside the existing_32_BIT/little.GO_*branches are matched first (authoritative when the GO subclass is present); theACQ_word_sizebranches are the fallback for data with noGO_*subclass. PV360 data carries noGO_raw_data_format, so the GO branches simply don't match it and the ordering is safe.Genuinely version-dependent selection is left alone — in particular
job_desc, whoseACQ_jobsstruct layout really does differ between PV-360 releases, keeps its version conditions (including<PV-360.1.1>). This PR deliberately does not touch the PV-360 version enumeration discussed in #41.Coverage / datasets
rawdata.jobN(hasGO_raw_data_format) and PV360rawdata.jobN(hasACQ_word_size, noGO_*) both resolve as before on the data I have — all_32_BIT/little: MRIReco.jl PV360 CS FLASH, BrukerPV360_StdDatav3.6, Bruker PCI PV360 standard datasets.ACQ_word_size=_16_BITorBYTORDA=big, so the new 16-bit / big-endian branches are not exercised by a public fixture; they close a documentedACQ_word_size/BYTORDAgap (_16_BITis listed in the Parameter Reference and appears in the ParaVision install source).🤖 Generated with Claude Code