Skip to content

[_825] pam_interactive: reconcile / document Python and C++ client plugin differences #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d-w-moore wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[_825] pam_interactive: reconcile / document Python and C++ client plugin differences #826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions irods/auth/pam_interactive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,17 @@
resp['user_name'] = self.conn.account.proxy_user
resp['zone_name'] = self.conn.account.proxy_zone

#TODO check handling of FORCE_PASSWORD_PROMPT -

Check failure on line 75 in irods/auth/pam_interactive.py

View workflow job for this annotation

GitHub Actions / ruff-lint / ruff-check

Ruff missing-todo-link 

missing-todo-link: Missing issue link for this TODO [check:missing-todo-link]

Check failure on line 75 in irods/auth/pam_interactive.py

View workflow job for this annotation

GitHub Actions / ruff-lint / ruff-check

Ruff missing-todo-colon 

missing-todo-colon: Missing colon in TODO [check:missing-todo-colon]

Check failure on line 75 in irods/auth/pam_interactive.py

View workflow job for this annotation

GitHub Actions / ruff-lint / ruff-format

Ruff format 

Improper formatting
# This is close to what the C++ plugin (client-side) does
# If not forcing a prompt, check for existing credentials (.irodsA) to attempt native auth directly
if not resp.get(FORCE_PASSWORD_PROMPT, False):
if self.conn.account.password and self.conn.account.derived_auth_file:
resp[__NEXT_OPERATION__] = PERFORM_NATIVE_AUTH
return resp

# TODO

Check failure on line 83 in irods/auth/pam_interactive.py

View workflow job for this annotation

GitHub Actions / ruff-lint / ruff-check

Ruff missing-todo-link 

missing-todo-link: Missing issue link for this TODO [check:missing-todo-link]

Check failure on line 83 in irods/auth/pam_interactive.py

View workflow job for this annotation

GitHub Actions / ruff-lint / ruff-check

Ruff missing-todo-description 

missing-todo-description: Missing issue description after `TODO` [check:missing-todo-description]

Check failure on line 83 in irods/auth/pam_interactive.py

View workflow job for this annotation

GitHub Actions / ruff-lint / ruff-check

Ruff missing-todo-colon 

missing-todo-colon: Missing colon in TODO [check:missing-todo-colon]
# iRODS4j removes the passworda property from the response object

# Otherwise, begin the full interactive flow
resp[__NEXT_OPERATION__] = AUTH_CLIENT_AUTH_REQUEST
return resp
Expand Down Expand Up @@ -199,6 +204,7 @@
if not self.depot:
raise RuntimeError("auth storage object was either not set, or allowed to expire prematurely.")

# TODO: review (iRODS4j doesn't do this).

Check failure on line 207 in irods/auth/pam_interactive.py

View workflow job for this annotation

GitHub Actions / ruff-lint / ruff-check

Ruff missing-todo-link 

missing-todo-link: Missing issue link for this TODO [check:missing-todo-link]
if request.get(STORE_PASSWORD_IN_MEMORY):
self.depot.use_client_auth_file(None)

Expand Down
Loading