Skip to content

[21] add Koutheir's pretty printers for STL in libcxx - #22

Draft
d-w-moore wants to merge 6 commits into
irods:mainfrom
d-w-moore:koutheir
Draft

[21] add Koutheir's pretty printers for STL in libcxx#22
d-w-moore wants to merge 6 commits into
irods:mainfrom
d-w-moore:koutheir

Conversation

@d-w-moore

Copy link
Copy Markdown
Contributor

No description provided.

@d-w-moore
d-w-moore marked this pull request as draft January 3, 2021 22:10
@trel

trel commented Jan 3, 2021

Copy link
Copy Markdown
Member

can we parameterize the script a bit - or pick up the clang and cmake versions from somewhere else? I feel this will perhaps grow stale and forgotten...

@d-w-moore

Copy link
Copy Markdown
Contributor Author

Agreed, maybe collect these parameters into defaults (as environment variables overrideable via arguments) near head of script. It's not too hard to compute latest version of cmake in externals. And relevant commit for pretty printers will have to be a function of the clang / libcxx version.

Comment thread koutheir-pretty-printers.sh Outdated
Comment thread koutheir-pretty-printers.sh Outdated
@@ -0,0 +1,125 @@
#!/bin/bash

if [ ${CHK-1} ] ; then

@d-w-moore d-w-moore Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this 'if' when done with troubleshooting

fi

echo >&2 -e "\n--> Creating $HOME/.gdbinit for gdb and rr.\n"
cd ~ ; git clone https://github.com/koutheir/libcxx-pretty-printers

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we clone this repository into the irods namespace? we do this for most everything else we use...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. Clone away, and I will change the reference.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants