A2: marker [❌ USUNIĘTY] przez with_deleted_marker#613
Open
mpasternak wants to merge 1 commit into
Open
Conversation
Sześć modeli-luster PBN (institution/publication/conference/publisher/
journal/scientist) duplikowało w __str__ ten sam blok
`if is_deleted: ret = f"[❌ USUNIĘTY] {ret}"`. Zastąpione wspólnym helperem
`self.with_deleted_marker(ret)` z BasePBNMongoDBModel (django-pbn-client 0.2.2).
Zachowanie pinowane istniejącym test_models_deleted_marker.py (6 modeli × 2)
— przechodzi bez zmian.
Zależność django-pbn-client 0.2.2 pinowana git-source (do usunięcia po PyPI).
Stack: na feat/pbn-d3-dict-sync.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cel
Sześć modeli-luster PBN (
institution,publication,conference,publisher,journal,scientist) duplikowało w__str__identyczny blok:Zastąpione wspólnym
return self.with_deleted_marker(ret)zBasePBNMongoDBModel(django-pbn-client 0.2.2, django-pbn-client#4).Byte-identyczność
Istniejący
test_models_deleted_marker.py(6 modeli × 2: deleted-ma-marker,active-bez) przechodzi bez zmian — dowód, że zachowanie markera jest
identyczne. 12 passed.
Poza zakresem
bpp/views/autocomplete/authors.pyteż używa literału[❌ USUNIĘTY], ale winnym kontekście (budowa części stringa, nie
__str__modelu) — zostaje.Zależność / merge order
django-pbn-clientpinowany git-source dofeat/deleted-marker. Po wydaniu0.2.2 na PyPI usunąć wpis. Merge po django-pbn-client#4.
Stack: na
feat/pbn-d3-dict-sync(#612).🤖 Generated with Claude Code