ci: stop installing the mcap CLI in CI#22
Merged
Conversation
The `mcap` CLI is meant for local fixture regeneration/debugging, not as a CI dependency. gen-test-mcap-filtered.mjs already self-skips (exit 0, no output file) when the binary isn't on PATH, and the one Playwright spec that depends on test_multi_filtered.mcap already skips itself when the fixture is absent, so removing the install step just means that one derived fixture/test no longer runs in CI; every other fixture and test is unaffected.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #21: the
mcapCLI is a local-only debugging tool for regeneratingtest_multi_filtered.mcap, not something CI should install.gen-test-mcap-filtered.mjsalready self-skips when the binary isn't on PATH, and the one Playwright spec depending on that fixture already skips itself when it's absent, so removing the CI install step just means that one derived fixture/test no longer runs there; everything else is unaffected.