Skip to content

[Bindless] Fix fetch_image on sampled handles to use sampled image path #22955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Seanst98 wants to merge 1 commit into
base: sycl
Choose a base branch
from
+4 −8
Open

[Bindless] Fix fetch_image on sampled handles to use sampled image path #22955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions sycl/include/sycl/ext/oneapi/bindless_images.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,19 +1036,15 @@ DataT fetch_image(const sampled_image_handle &imageHandle [[maybe_unused]],
"HintT must always be a recognized standard type");

#ifdef __SYCL_DEVICE_ONLY__
// Convert the raw handle to an image and use FETCH_UNSAMPLED_IMAGE since
// fetch_image should not use the sampler
if constexpr (detail::is_recognized_standard_type<DataT>()) {
return FETCH_UNSAMPLED_IMAGE(
return FETCH_SAMPLED_IMAGE(
DataT,
CONVERT_HANDLE_TO_IMAGE(imageHandle.raw_handle,
detail::OCLImageTyRead<coordSize>),
CONVERT_HANDLE_TO_SAMPLED_IMAGE(imageHandle.raw_handle, coordSize),
coords);
} else {
return sycl::bit_cast<DataT>(FETCH_UNSAMPLED_IMAGE(
return sycl::bit_cast<DataT>(FETCH_SAMPLED_IMAGE(
HintT,
CONVERT_HANDLE_TO_IMAGE(imageHandle.raw_handle,
detail::OCLImageTyRead<coordSize>),
CONVERT_HANDLE_TO_SAMPLED_IMAGE(imageHandle.raw_handle, coordSize),
coords));
}
#else
Expand Down
Loading