fix: lint:changes command to only lint changed files - #2665
Open
joyenjoyer wants to merge 2 commits into
Open
Conversation
Contributor
|
joyenjoyer
force-pushed
the
lint_changes_fix
branch
2 times, most recently
from
July 29, 2026 11:34
f69eb89 to
b60b30a
Compare
Contributor
Visual regression report
Diff images (33)alert.png — baseline no longer producedavatar.png — baseline no longer producedbadge.png — baseline no longer producedbillboard.png — baseline no longer producedbreadcrumb.png — baseline no longer producedbutton-and-derivatives.png — baseline no longer producedbyline.png — baseline no longer producedcalendar.png — baseline no longer producedcheckbox.png — baseline no longer producedcheckboxgroup.png — baseline no longer producedcolorpicker.png — baseline no longer producedcontextview.png — baseline no longer producedcustom-and-lucide-icons.png — baseline no longer produceddateinput-dateinput2.png — baseline no longer produceddatetimeinput.png — baseline no longer produceddiff-demo.png — 6324 pixels differdrilldown.png — baseline no longer producedfiledrop.png — baseline no longer producedform-errors.png — baseline no longer producedheading.png — baseline no longer producedimg.png — baseline no longer producedlink.png — baseline no longer producedmenu.png — baseline no longer producedmetric-pill-tag-timeselect-text.png — baseline no longer producedoptions.png — baseline no longer producedpagination.png — baseline no longer producedprogressbar.png — baseline no longer producedselect-simpleselect.png — baseline no longer producedtable.png — baseline no longer producedtabs.png — baseline no longer producedtooltip.png — baseline no longer producedtreebrowser.png — baseline no longer producedview.png — baseline no longer producedBaselines come from the |
joyenjoyer
changed the base branch from
master
to
fix-regression-a11y-screenshot-decouple
August 3, 2026 11:23
joyenjoyer
changed the base branch from
fix-regression-a11y-screenshot-decouple
to
master
August 3, 2026 11:23
Replace the broken --since flag with proper merge-base diff logic. The command now gets files changed since merge-base with master and passes them directly to oxlint instead of routing through the workspace runner which would lint the entire codebase.
joyenjoyer
force-pushed
the
lint_changes_fix
branch
from
August 3, 2026 11:25
b60b30a to
e5b15d7
Compare
balzss
requested changes
Aug 12, 2026
balzss
left a comment
balzss
left a comment
Contributor
There was a problem hiding this comment.
this command breaks workflows without js/ts changes since oxlint exits with 1. ironically this very PR is a good example
…anged Filter the changed-file list to lintable extensions before handing it to oxlint, so it's only invoked when there's actually something to lint.
joyenjoyer
commented
Aug 12, 2026
| "test:browser-ui": "pnpm run playwright:install && vitest --project browser --browser.headless=false --ui", | ||
| "lint": "pnpm -r --stream lint", | ||
| "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | xargs -r oxlint --format=unix", | ||
| "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | { grep -E '\\.(js|jsx|ts|tsx|mjs|cjs)$' || true; } | xargs -r oxlint --format=unix", |
Contributor
Author
There was a problem hiding this comment.
- git diff: list files changed since branching from master
- grep (+ || true): keep only lintable extensions; don't fail if none match
- xargs -r oxlint: only run oxlint if files remain, so no-match no longer exits 123
balzss
requested changes
Aug 19, 2026
balzss
left a comment
balzss
left a comment
Contributor
There was a problem hiding this comment.
Issue with the current solution: git diff --name-only also lists deleted files, and oxlint exits 1 (No files found to lint) when every path it gets no longer exists — so a PR whose only lintable change is a deletion (e.g. removing an obsolete test) will fail the lint job. The pre-commit hook won't catch it either, since lint-staged skips deleted files.
Suggested fix: add --diff-filter=ACMR to the git diff call so deleted paths never reach oxlint.
please note that the fix was suggested by claude and needs a double check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--since HEAD^flag withgit merge-baseto properly target changed filesTest Plan
pnpm run lint:changesnow only lints files in the diff since merge-baseFixes INSTUI-5090