feat: update to go public - #6
Conversation
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go |  |
Jul 30, 2026 10:45a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
There was a problem hiding this comment.
🟡 Not ready to approve
The inlined pre-commit configuration introduces a validate-manifest hook that will fail because the repository does not include a .pre-commit-hooks.yaml manifest (and the files regex should be tightened).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR updates repository configuration to support “going public” by removing organization-private dependencies from security/scanning and developer tooling configuration.
Changes:
- Removes an internal path comment from the Trivy config data registry allowlist.
- Replaces a private-repo (
ops-common) pre-commit dependency with inlinedrepo: localhooks. - Simplifies the documented pre-commit installation instructions by removing the post-checkout hook mention.
File summaries
| File | Description |
|---|---|
| .trivy_data.yaml | Adjusts trusted registry configuration to remove an internal comment reference. |
| .pre-commit-config.yaml | Inlines pre-commit hooks locally to avoid SSH/private repo dependency and updates usage docs. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Low
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| - id: pre-commit-validate-manifest | ||
| name: pre-commit/validate-manifest | ||
| files: .pre-commit-config.yaml | ||
| entry: pre-commit validate-manifest | ||
| language: system | ||
| always_run: false | ||
| pass_filenames: false |
implement [ENG-9423]
There was a problem hiding this comment.
🟡 Not ready to approve
The new local shfmt hook uses long-form CLI flags that are likely invalid for the standard shfmt binary, which would break pre-commit runs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
Comments suppressed due to low confidence (1)
.pre-commit-config.yaml:70
- The shfmt hook is configured with long-form flags (
--list/--write/--diff/--indent), but the standardshfmtbinary (as installed via the documentedbrew install ... shfmt) uses short flags (-l/-w/-d/-i). With the current args, this hook is likely to fail with an "unknown flag" error when it runs.
args: [--list, --write, --diff, --indent, "4"]
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Low
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
implement ENG-9423
update to go public