feat: add optional runc support and generic runtime configuration - #34
Merged
Conversation
Add a checksum-pinned runc payload and propagate its opt-in setting through image builds, standalone, Helm, and supported Terraform paths. Point the sandboxd submodule at the merged upstream backend revision so clean builds contain the implementation that they configure. Keep runc excluded and unadvertised by default because it shares the host kernel and has a different isolation boundary from runsc. Signed-off-by: Tianyu Zhou <albert.zty@antgroup.com>
Add a runtime-agnostic, JSON-compatible extra_config argument to Sandbox and forward it through both YuanRong backends without interpreting fields owned by a runtime. Validate and defensively copy nested values so callers cannot mutate submitted options. Cover the public API and both wire paths with neutral custom-runtime fixtures instead of exposing enableKVM as a test API. Signed-off-by: Tianyu Zhou <albert.zty@antgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds optional runc support to the AKernel all-in-one image and exposes a generic
Sandbox(extra_config=...)extension for runtime-owned configuration.Runc remains disabled and unadvertised by default. When enabled, its checksum-pinned binaries are included in the image and the setting is propagated through standalone, Helm, and supported Terraform deployments. The sandboxd submodule is updated to the merged runc backend revision.
extra_configaccepts JSON-compatible values and is forwarded without interpretation through bothopenyuanrong-sandboxandopenyuanrong-sdk. It is runtime-agnostic and does not expose fields such asenableKVMas dedicated SDK parameters.Validation
git diff --check.