upgrade quic-go to v0.59.0, fix Go 1.25 compatibility#485
Closed
DAcodedBEAT wants to merge 1 commit into
Closed
Conversation
- Remove deprecated ConnectionTracingID/ConnectionTracingKey - Replace hijacker callbacks with RawClientConn (upstream API) - Fix SupportsDatagrams.Remote check - Add transport tests Fixes imroc#482
Author
|
For those following along, if you want to use this change, feel free to run: And to revert once upstream has the fix: update(2026.02.20) : edited replace to be all CLI driven via |
|
@imroc Hi, have you got any time to merge this please? 🙏 |
|
Would be awesome if we can get this merged :) |
Contributor
|
it is not active for longtime |
|
@imroc Can you take a look at this? |
|
@imroc Can we get this merged please? 🙏 |
|
Does anyone know what's going on? Why is the library author taking so long to approve this merge? |
|
@imroc 🙏 |
|
@imroc 可以抽些时间合并一下PR吗🙏🙏🙏 |
imroc
added a commit
that referenced
this pull request
Jun 27, 2026
- Remove deprecated ConnectionTracingID/ConnectionTracingKey - Remove stream hijacking API (StreamHijacker/UniStreamHijacker) - Replace handleUnidirectionalStreams loop with handleUnidirectionalStream per-stream callback, add startUnidirectionalStreamAcceptLoop - Add RawClientConn for fine-grained stream control (WebTransport etc.) - Add HandleBidirectionalStream (closes conn per RFC 9114) - Move rcvdControlStr/rcvdQPACKEncoderStr/rcvdQPACKDecoderStr to Conn struct - Fix SupportsDatagrams -> SupportsDatagrams.Remote - Move atomic.Bool tracking from local vars to Conn struct fields Aligns with quic-go v0.59.0 breaking changes (#5508, #5509, #5512, #5521, #5533). Fixes #482. Reviewed PR #485 by DAcodedBEAT, verified modified-code compatibility.
Owner
|
Thanks @DAcodedBEAT for this PR! It was used as a reference for the fix that was merged in commit 8b018a5. The quic-go v0.59.0 port is now live on master. Closing this in favor of the merged fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this as I was upgrading to go 1.25.6.
PR Includes:
Fixes #482