Skip to content

Add SkipEnabledCheck=true to ConnectionSelected log message - #665

Merged
imperugo merged 1 commit into
imperugo:masterfrom
LeaFrock:issue661
Aug 6, 2026
Merged

Add SkipEnabledCheck=true to ConnectionSelected log message#665
imperugo merged 1 commit into
imperugo:masterfrom
LeaFrock:issue661

Conversation

@LeaFrock

@LeaFrock LeaFrock commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Avoid unnecessary double enabled check.

Motivation

Closes #661

Changes

  • Add SkipEnabledCheck = true to LogMessages.ConnectionSelected

Checklist

  • Code compiles without warnings (TreatWarningsAsErrors is enabled)
  • Tests pass locally (dotnet test)
  • New code has test coverage
  • No breaking changes to public API (or documented in PR description)

@imperugo

imperugo commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Thanks @LeaFrock — merging this.

The // Check by the caller comment is exactly what this needed: SkipEnabledCheck = true turns "the caller guards" into a contract, and without that note the next person to add a call-site would silently pay the full formatting cost on the hottest path in the library. Good catch on the two stale usings too — the Core.Extensions one was left over from the MinBy removal in #659.

This ships with the v13.5 release, once the rest of that milestone lands.

@imperugo
imperugo merged commit 4f429b1 into imperugo:master Aug 6, 2026
4 checks passed
@LeaFrock
LeaFrock deleted the issue661 branch August 8, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SkipEnabledCheck to ConnectionSelected log message

2 participants