Skip to content

Replace CollectionsMarshal.AsSpan with IList<T> indexing in ToFastArray #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imperugo merged 2 commits into from
Aug 7, 2026
Merged

Replace CollectionsMarshal.AsSpan with IList<T> indexing in ToFastArray #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9fe333
Replace `CollectionsMarshal.AsSpan` with `IList<T>` indexing in `ToFa…
LeaFrock Aug 4, 2026
2f4852e
Merge master: line ending normalization (.gitattributes)
imperugo Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions src/core/StackExchange.Redis.Extensions.Core/Extensions/GenericsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
using System;
using System.Collections.Generic;

namespace StackExchange.Redis.Extensions.Core.Extensions;

internal static class GenericsExtensions
{
public static TResult[] ToFastArray<TSource, TResult>(this ReadOnlySpan<TSource> source, Func<TSource, TResult> action)
{
if (source.IsEmpty)
return [];

var result = new TResult[source.Length];
for (var i = 0; i < source.Length; i++)
result[i] = action.Invoke(source[i]);

return result;
}

public static TResult[] ToFastArray<TSource, TResult>(this ICollection<TSource>? source, Func<TSource, TResult> action)
{
if (source is not { Count: > 0 })
return [];

if (source is TSource[] sourceArray)
return sourceArray.AsSpan().ToFastArray(action);

if (source is IList<TSource> sourceList)
{
var listResult = new TResult[sourceList.Count];
for (var i = 0; i < listResult.Length; i++)
listResult[i] = action.Invoke(sourceList[i]);

return listResult;
}

var result = new TResult[source.Count];
var index = 0;
foreach (var item in source)
result[index++] = action.Invoke(item);

return result;
}
}
13 changes: 0 additions & 13 deletions src/core/StackExchange.Redis.Extensions.Core/Extensions/SpanExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,4 @@ public static void EnumerateLines(this ReadOnlySpan<char> span, ref List<InfoDet
}
}
}

public static TResult[] ToFastArray<TSource, TResult>(this ReadOnlySpan<TSource> span, Func<TSource, TResult> action)
{
if (span.IsEmpty)
return [];

var result = new TResult[span.Length];

for (var i = 0; i < span.Length; i++)
result[i] = action.Invoke(span[i]);

return result;
}
}
63 changes: 0 additions & 63 deletions src/core/StackExchange.Redis.Extensions.Core/Helpers/GenericsExtensions.cs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/core/StackExchange.Redis.Extensions.Core/Implementations/RedisDatabase.Bitmap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
using System;
using System.Threading.Tasks;

using StackExchange.Redis.Extensions.Core.Helpers;
using StackExchange.Redis.Extensions.Core.Extensions;

namespace StackExchange.Redis.Extensions.Core.Implementations;

Expand Down
2 changes: 1 addition & 1 deletion src/core/StackExchange.Redis.Extensions.Core/Implementations/RedisDatabase.Geo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

using System.Threading.Tasks;

using StackExchange.Redis.Extensions.Core.Helpers;
using StackExchange.Redis.Extensions.Core.Extensions;

namespace StackExchange.Redis.Extensions.Core.Implementations;

Expand Down
2 changes: 1 addition & 1 deletion src/core/StackExchange.Redis.Extensions.Core/Implementations/RedisDatabase.Hash.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
using System.Linq;
using System.Threading.Tasks;

using StackExchange.Redis.Extensions.Core.Helpers;
using StackExchange.Redis.Extensions.Core.Extensions;

namespace StackExchange.Redis.Extensions.Core.Implementations;

Expand Down
2 changes: 1 addition & 1 deletion src/core/StackExchange.Redis.Extensions.Core/Implementations/RedisDatabase.HyperLogLog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
using System;
using System.Threading.Tasks;

using StackExchange.Redis.Extensions.Core.Helpers;
using StackExchange.Redis.Extensions.Core.Extensions;

namespace StackExchange.Redis.Extensions.Core.Implementations;

Expand Down
2 changes: 1 addition & 1 deletion src/core/StackExchange.Redis.Extensions.Core/Implementations/RedisDatabase.List.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
using System.Collections.Generic;
using System.Threading.Tasks;

using StackExchange.Redis.Extensions.Core.Helpers;
using StackExchange.Redis.Extensions.Core.Extensions;

namespace StackExchange.Redis.Extensions.Core.Implementations;

Expand Down
2 changes: 1 addition & 1 deletion src/core/StackExchange.Redis.Extensions.Core/Implementations/RedisDatabase.PubSub.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
using System.Collections.Generic;
using System.Threading.Tasks;

using StackExchange.Redis.Extensions.Core.Helpers;
using StackExchange.Redis.Extensions.Core.Extensions;
using StackExchange.Redis.Extensions.Core.Logging;

namespace StackExchange.Redis.Extensions.Core.Implementations;
Expand Down
3 changes: 1 addition & 2 deletions src/core/StackExchange.Redis.Extensions.Core/Implementations/RedisDatabase.Sort.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
// Copyright (c) Ugo Lattanzi. All Rights Reserved. Licensed under the MIT license. See License.txt in the project root for license information.

using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;

using StackExchange.Redis.Extensions.Core.Helpers;
using StackExchange.Redis.Extensions.Core.Extensions;
using StackExchange.Redis.Extensions.Core.Models;

namespace StackExchange.Redis.Extensions.Core.Implementations;
Expand Down
2 changes: 1 addition & 1 deletion src/core/StackExchange.Redis.Extensions.Core/Implementations/RedisDatabase.Streams.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

using System.Threading.Tasks;

using StackExchange.Redis.Extensions.Core.Helpers;
using StackExchange.Redis.Extensions.Core.Extensions;

namespace StackExchange.Redis.Extensions.Core.Implementations;

Expand Down
1 change: 0 additions & 1 deletion src/core/StackExchange.Redis.Extensions.Core/Implementations/RedisDatabase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

using System;
using System.Collections.Generic;
using System.Linq;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using System.Threading.Tasks;
Expand Down
2 changes: 1 addition & 1 deletion tests/StackExchange.Redis.Extensions.Core.Tests/CacheClientTestBase.Hash.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
using System.Collections.Generic;
using System.Threading.Tasks;

using StackExchange.Redis.Extensions.Core.Helpers;
using StackExchange.Redis.Extensions.Core.Extensions;
using StackExchange.Redis.Extensions.Core.Tests.Helpers;

using Xunit;
Expand Down
4 changes: 1 addition & 3 deletions tests/StackExchange.Redis.Extensions.Core.Tests/CacheClientTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,9 @@

using NSubstitute;

using StackExchange.Redis;

using StackExchange.Redis.Extensions.Core.Abstractions;
using StackExchange.Redis.Extensions.Core.Configuration;
using StackExchange.Redis.Extensions.Core.Helpers;
using StackExchange.Redis.Extensions.Core.Extensions;
using StackExchange.Redis.Extensions.Core.Implementations;
using StackExchange.Redis.Extensions.Core.Tests.Helpers;
using StackExchange.Redis.Extensions.Tests.Extensions;
Expand Down
Loading