Generate hub embed font CSS safely - #8
Merged
Conversation
Add hub template fallback/override controls and ensure forced pages discard client-authored templates, CSS, and render configuration while retaining validated hash-keyed fonts through hub-generated presentation data. Protect hub-owned pages with nonce CSP and safe render JSON serialization. Inspired by mrexodia's work in #7. Co-authored-by: Duncan Ogilvie <mr.exodia.tpodt@gmail.com>
Carry over mrexodia's Windows-specific large-enum rationale from PR #7; the command enum is parsed once and immediately consumed, so boxing only shifts the size disparity. Co-authored-by: Duncan Ogilvie <mr.exodia.tpodt@gmail.com>
Escape only the less-than sign needed to protect inline script JSON, and emit already-validated hash family keys directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrutinize embed mode more. Font CSS is now hub generated and client CSS is not longer allowed. Normalize font family names.
Allow hub to force a template so clean a client can't inject anything besides content and fonts.