Skip to content

Work on max_cliques()#2717

Open
maelle wants to merge 3 commits into
mainfrom
cliques2
Open

Work on max_cliques()#2717
maelle wants to merge 3 commits into
mainfrom
cliques2

Conversation

@maelle

@maelle maelle commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

I am using Jarl's new unused_object check, that drew my attention to this function.

Comment thread R/cliques.R
length(grep("://", file, fixed = TRUE)) > 0 ||
length(grep("~", file, fixed = TRUE)) > 0
) {
tmpfile <- TRUE

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tmpfile was not returned!

@maelle maelle requested a review from schochastics June 29, 2026 12:58
Comment thread src/rinterface_extra.c
IGRAPH_R_CHECK(igraph_vector_int_init(&subset, 0));
}
IGRAPH_FINALLY_PV(igraph_vector_int_destroy, &subset);
#if HAVE_OPEN_MEMSTREAM == 1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently not used

@github-actions

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if caabe13 is merged into main:

  • ✔️as_adjacency_matrix: 774ms -> 775ms [-2.16%, +2.36%]
  • ✔️as_biadjacency_matrix: 771ms -> 765ms [-2.22%, +0.63%]
  • ✔️as_data_frame_both: 1.49ms -> 1.5ms [-1.5%, +2.34%]
  • ✔️as_long_data_frame: 3.92ms -> 4.04ms [-2.34%, +8.56%]
  • ✔️es_attr_filter: 2.93ms -> 2.94ms [-2.93%, +4.08%]
  • ✔️graph_from_adjacency_matrix: 126ms -> 126ms [-2.94%, +1.98%]
  • ✔️graph_from_data_frame: 3.43ms -> 3.42ms [-1.89%, +1.52%]
  • ✔️vs_attr_filter: 1.64ms -> 1.65ms [-2.71%, +3.46%]
  • ✔️vs_by_name: 1.14ms -> 1.12ms [-6.17%, +1.74%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant