Skip to content

Fix SonarQube code smells: @Service and @InjectMocks #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorsatsyuk merged 1 commit into from
Jul 22, 2026
Merged

Fix SonarQube code smells: @Service and @InjectMocks #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rvice/src/main/java/lt/satsyuk/distributed/audit/eventstore/service/EventHashService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package lt.satsyuk.distributed.audit.eventstore.service;

import org.springframework.stereotype.Component;
import org.springframework.stereotype.Service;

import java.nio.charset.StandardCharsets;
import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;

@Component
@Service
public class EventHashService {

private static final String SHA_256 = "SHA-256";
Expand Down
8 changes: 2 additions & 6 deletions ...t/java/lt/satsyuk/distributed/audit/query/repository/AuditLogQueryRepositoryImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package lt.satsyuk.distributed.audit.query.repository;

import lt.satsyuk.distributed.audit.query.service.AuditLogFilter;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import org.springframework.r2dbc.core.DatabaseClient;
Expand All @@ -27,13 +27,9 @@ class AuditLogQueryRepositoryImplTest {
@Mock
private DatabaseClient databaseClient;

@InjectMocks
private AuditLogQueryRepositoryImpl repository;

@BeforeEach
void setUp() {
repository = new AuditLogQueryRepositoryImpl(databaseClient);
}

// ---- escapeLikePattern ------------------------------------------------

@Test
Expand Down
8 changes: 2 additions & 6 deletions .../test/java/lt/satsyuk/distributed/audit/query/service/AuditIntegrityCheckServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
import lt.satsyuk.distributed.audit.query.blockchain.AuditLedgerBlockchainClient;
import lt.satsyuk.distributed.audit.query.model.AuditEventRecord;
import lt.satsyuk.distributed.audit.query.repository.AuditLogQueryRepository;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import reactor.core.publisher.Mono;
Expand All @@ -30,13 +30,9 @@ class AuditIntegrityCheckServiceTest {
@Mock
private AuditLedgerBlockchainClient blockchainClient;

@InjectMocks
private AuditIntegrityCheckService service;

@BeforeEach
void setUp() {
service = new AuditIntegrityCheckService(auditLogQueryRepository, blockchainClient);
}

@Test
void checkIntegrityReturnsOnChainWhenHashIsAnchored() {
AuditEventRecord eventRecord = sampleRecord(10L, HASH_64);
Expand Down
8 changes: 2 additions & 6 deletions ...ce/src/test/java/lt/satsyuk/distributed/audit/query/service/AuditLogQueryServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
import lt.satsyuk.distributed.audit.query.mapper.AuditEventDtoMapper;
import lt.satsyuk.distributed.audit.query.model.AuditEventRecord;
import lt.satsyuk.distributed.audit.query.repository.AuditLogQueryRepository;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.ArgumentCaptor;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import reactor.core.publisher.Flux;
Expand Down Expand Up @@ -36,13 +36,9 @@ class AuditLogQueryServiceTest {
@Mock
private AuditEventDtoMapper mapper;

@InjectMocks
private AuditLogQueryService service;

@BeforeEach
void setUp() {
service = new AuditLogQueryService(auditLogQueryRepository, mapper);
}

@Test
void findAuditLogsAppliesFilterAndMapsRecords() {
AuditEventRecord eventRecord = sampleRecord();
Expand Down
8 changes: 2 additions & 6 deletions ...e/src/test/java/lt/satsyuk/distributed/audit/query/service/BatchIntegrityCheckerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
import lt.satsyuk.distributed.audit.query.blockchain.AuditLedgerBlockchainClient;
import lt.satsyuk.distributed.audit.query.model.AuditEventRecord;
import lt.satsyuk.distributed.audit.query.repository.AuditLogQueryRepository;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import reactor.core.publisher.Flux;
Expand All @@ -31,13 +31,9 @@ class BatchIntegrityCheckerTest {
@Mock
private AuditLedgerBlockchainClient blockchainClient;

@InjectMocks
private BatchIntegrityChecker checker;

@BeforeEach
void setUp() {
checker = new BatchIntegrityChecker(auditLogQueryRepository, blockchainClient);
}

@Test
void runCheckAggregatesOnChainPendingAndMismatchAcrossBatches() {
AuditEventRecord onChain = buildEventRecord(1L, "evt-1", HASH_1);
Expand Down