OF-3187: Make AuthCheckFilter's destroy a no-op - #3154
Merged
Conversation
Fishbowler
force-pushed
the
fix-authcheckfilter
branch
2 times, most recently
from
March 5, 2026 14:07
efc8c4a to
c577bfa
Compare
guusdk
approved these changes
Mar 6, 2026
guusdk
left a comment
guusdk
left a comment
Member
There was a problem hiding this comment.
Looks good. Can you tempt you to create a JIRA issue for this and reword the commit message to reference the new JIRA number? That way, things get tracked for future-us.
This is called when the AdminConsolePlugin restarts (by PluginServlet). It wipes all exclusions that have been registered, requiring plugins to re-register them. This change retains the static list of excludes. Plugins remain responsible for unregistering their excludes, which they should have been doing anyway, rather than relying on an eventual restart of the AdminConsole.
Fishbowler
force-pushed
the
fix-authcheckfilter
branch
from
March 6, 2026 20:08
c577bfa to
b8cf466
Compare
Fishbowler
changed the title
Member
Author
|
Jira: ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is called when the AdminConsolePlugin restarts (by PluginServlet). It wipes all exclusions that have been registered, requiring plugins to re-register them. This change retains the static list of excludes. Plugins remain responsible for unregistering their excludes, which they should have been doing anyway, rather than relying on an eventual restart of the AdminConsole.
Fixes the generic case of igniterealtime/openfire-restAPI-plugin#205 (which has a fix in igniterealtime/openfire-restAPI-plugin#232, but feels like it should be unnecessary)