Ice in kinematic 2D#492
Open
AgnieszkaMakulska wants to merge 15 commits into
Open
Conversation
…phxx into kinematic_ice
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the kinematic_2D Lagrangian (lgrngn) model configuration to support ice-related toggles and diagnostics/output, and introduces a new aerosol composition parameter (soluble_fraction).
Changes:
- Added
out_iceparsing and diagnostics output for ice moments in the kinematic_2D lgrngn model. - Introduced CLI options to control ice-related processes (
ice_switch,ice_nucl,time_dep_ice_nucl) and added a newdepotoggle to lgrngnopts_t. - Added
soluble_fractionto the kinematic_2D setup/options and attempted to use it in aerosol initialization.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| models/kinematic_2D/src/opts_lgrngn.hpp | Adds CLI options and output parsing for ice, plus updates aerosol init keying logic. |
| models/kinematic_2D/src/opts_common.hpp | Adds soluble_fraction option and stores it in the case setup. |
| models/kinematic_2D/src/kin_cloud_2d_lgrngn.hpp | Adds ice diagnostics output (ice_mix_ratio, ice_a, ice_c) and stores ice-related constants. |
| models/kinematic_2D/cases/icmw8_case1.hpp | Extends setup_t with soluble_fraction. |
| include/libcloudph++/lgrngn/opts.hpp | Adds depo toggle to the lgrngn runtime options struct. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
307
to
310
| rt_params.cloudph_opts_init.dry_distros.emplace( | ||
| libcloudphxx::lgrngn::kappa_rd_insol_t<config::real_t>{setup.kappa, config::real_t(0.)}, // kappa, rd_insol | ||
| libcloudphxx::lgrngn::kappa_soluble_fraction_t<config::real_t>{setup.kappa, setup.soluble_fraction}, | ||
| std::make_shared<config::log_dry_radii<config::real_t>> (setup) | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.