Fix historical price resolutions on pandas 3 - #376
Open
prbprbprb wants to merge 1 commit into
Open
Conversation
pandas 3.0 removes the 'H' and 'M' frequency aliases, so conv_resol() will raise ValueError for 1H, 2H, 3H, 4H and M, the resolutions that fetch_historical_prices docstrings advertise. This change normalises them to 'h' and 'ME' before calling to_offset(), so both spellings work on pandas 2 and 3, and neither triggers the pandas 2 deprecation warning. Partially fixes ig-python#375 Noted while testing that conv_resol fails anyway on pandas 2.0 and 2.1 so I'm planning to bump the minimum in the next (test matrix) PR as it doesn't make anything worse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pandas 3.0 removes the 'H' and 'M' frequency aliases, so conv_resol() will raise ValueError for 1H, 2H, 3H, 4H and M, the resolutions that fetch_historical_prices docstrings advertise.
This change normalises them to 'h' and 'ME' before calling to_offset(), so both spellings work on pandas 2 and 3, and neither triggers the pandas 2 deprecation warning.
Partially fixes #375
Noted while testing that conv_resol fails anyway on pandas 2.0 and 2.1 so I'm planning to bump the minimum in the next (test matrix) PR as it doesn't make anything worse