[patch] pipeline-db2-license secret not created when Slack is not configured Slack config / exclude openshift integration tests from standard CI run - #436
Closed
prveenkumr wants to merge 2 commits into
Closed
Conversation
…figured Slack config [fix] pipeline-db2-license secret not created when Slack is not configured The prepareUpdateSecrets() function in tekton.py was introduced in PR #425 ("day2 fix for devops slack secret issue") which added an early return when slack_token or slack_channel are not provided. This inadvertently placed the pipeline-db2-license secret creation after the early return, meaning the secret was never created for users who do not have Slack configured. The PipelineRun template (pipelinerun-update.yml.j2) unconditionally binds the shared-db2 workspace to secretName: pipeline-db2-license. When the secret does not exist, the update-db2 task pod is stuck in Init:0/2 with repeated FailedMount errors, blocking the entire mas-update pipeline run. Fix: move pipeline-db2-license secret creation before the Slack guard so it is always created regardless of whether Slack credentials are provided. Fixes: update-db2 pod stuck at Init:0/2 — FailedMount: secret "pipeline-db2-license" not found
Add \`-m \"not openshift\"\` to pytest invocation in python-package.yml to prevent OLM integration tests from running in environments without the IBM operator catalog installed. Tests in test_olm.py require a live OpenShift cluster with ibm-sls available in openshift-marketplace. The \`openshift\` marker was already defined in pyproject.toml but was not being applied during CI.
Contributor
Author
|
prveenkumr
changed the title
prveenkumr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[patch] pipeline-db2-license secret not created when Slack is not configured Slack config
[fix] pipeline-db2-license secret not created when Slack is not configured
The prepareUpdateSecrets() function in tekton.py was introduced in PR 425
("day2 fix for devops slack secret issue") which added an early return when
slack_token or slack_channel are not provided. This inadvertently placed the
pipeline-db2-license secret creation after the early return, meaning the
secret was never created for users who do not have Slack configured.
The PipelineRun template (pipelinerun-update.yml.j2) unconditionally binds
the shared-db2 workspace to secretName: pipeline-db2-license. When the
secret does not exist, the update-db2 task pod is stuck in Init:0/2 with
repeated FailedMount errors, blocking the entire mas-update pipeline run.
Fix: move pipeline-db2-license secret creation before the Slack guard so it
is always created regardless of whether Slack credentials are provided.
Fixes: update-db2 pod stuck at Init:0/2 — FailedMount: secret
"pipeline-db2-license" not found
[patch] exclude openshift integration tests from standard CI run
Add `-m "not openshift"` to pytest invocation in python-package.yml
to prevent OLM integration tests from running in environments without
the IBM operator catalog installed.
Tests in test_olm.py require a live OpenShift cluster with ibm-sls
available in openshift-marketplace. The `openshift` marker was already
defined in pyproject.toml but was not being applied during CI.