Replace prettier with oxfmt - #1776
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the repo’s formatting tooling from prettier (plus @ianvs/prettier-plugin-sort-imports) to oxfmt, updating configuration and CI to use the new formatter.
Changes:
- Replace
prettierscripts/dependencies withoxfmt(format/format:fix) and update CI to run the new check. - Add
.oxfmtrc.jsonto configure formatting and import sorting; remove.prettierrcand.prettierignore. - Regenerate
pnpm-lock.yamlaccordingly and apply formatting output changes in a TSX file.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
package.json |
Swaps formatter scripts and devDependency from prettier to oxfmt. |
pnpm-lock.yaml |
Updates lockfile for removed prettier deps and added oxfmt (incl. platform bindings). |
.oxfmtrc.json |
Introduces oxfmt configuration (formatting + import sorting + ignore patterns). |
.github/workflows/ci.yml |
Replaces the “Run prettier” step with “Run oxfmt” (pnpm format). |
packages/tree-widget/src/tree-widget-react/components/trees/common/UseTelemetryContext.tsx |
Formatting-only change consistent with formatter migration. |
.prettierrc |
Removed in favor of .oxfmtrc.json. |
.prettierignore |
Removed in favor of ignorePatterns in .oxfmtrc.json. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Tree-Widget benchmark
| Benchmark suite | Current: 39abe70 | Previous: 00e1622 | Deviation | Status |
|---|---|---|---|---|
models tree creates initial filtered view for 50k target items |
754 ms |
783 ms |
-3.70% |
〰️ |
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) |
54 ms |
49 ms |
10.20% |
〰️ |
models tree validates categories visibility for imodel with 50k categories |
6289 ms |
6439 ms |
-2.33% |
〰️ |
models tree validates categories visibility for imodel with 50k categories (P95 of main thread blocks) |
82 ms |
83 ms |
-1.20% |
〰️ |
models tree changing model visibility changes visibility for 50k elements |
2406 ms |
2568 ms |
-6.31% |
〰️ |
models tree changing model visibility changes visibility for 50k elements (P95 of main thread blocks) |
0 ms |
103 ms |
-100% |
✅ |
models tree changing category visibility changes visibility for 50k elements |
2472 ms |
2461 ms |
0.45% |
〰️ |
models tree changing category visibility changes visibility for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree changing per-model-category override changes visibility for 50k elements |
2252 ms |
2423 ms |
-7.06% |
〰️ |
models tree changing per-model-category override changes visibility for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree changing element visibility changes only parent nodes visibility with 50k elements |
3772 ms |
4034 ms |
-6.49% |
〰️ |
models tree changing element visibility changes only parent nodes visibility with 50k elements (P95 of main thread blocks) |
67 ms |
97 ms |
-30.93% |
〰️ |
categories tree creates initial filtered view for 50k items |
1768 ms |
1784 ms |
-0.90% |
〰️ |
categories tree creates initial filtered view for 50k items (P95 of main thread blocks) |
732 ms |
666 ms |
9.91% |
〰️ |
categories tree changing definition container visibility changes visibility for 50k subCategories |
2408 ms |
2475 ms |
-2.71% |
〰️ |
categories tree changing definition container visibility changes visibility for 50k subCategories (P95 of main thread blocks) |
41 ms |
55 ms |
-25.45% |
〰️ |
categories tree changing definition container visibility changes visibility for 50k categories |
4873 ms |
5183 ms |
-5.98% |
〰️ |
categories tree changing definition container visibility changes visibility for 50k categories (P95 of main thread blocks) |
104 ms |
118 ms |
-11.86% |
〰️ |
This comment was automatically generated by workflow using github-action-benchmark.
grigasp
approved these changes
Aug 13, 2026
JonasDov
requested changes
Aug 13, 2026
JonasDov
left a comment
Contributor
There was a problem hiding this comment.
Could you update recommended extensions in .vscode/extensions.json? Should remove prettier extension and add the oxc extension.
JonasDov
reviewed
Aug 13, 2026
JonasDov
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
prettierwithoxfmt. It is compatbile with prettier format, has built-in import sorter and is much faster than prettier.Closes #1773