Skip to content

Replace prettier with oxfmt - #1776

Merged
saskliutas merged 5 commits into
masterfrom
agents/migrate-prettier-to-oxfmt-monorepo
Aug 13, 2026
Merged

Replace prettier with oxfmt#1776
saskliutas merged 5 commits into
masterfrom
agents/migrate-prettier-to-oxfmt-monorepo

Conversation

@saskliutas

@saskliutas saskliutas commented Aug 12, 2026

Copy link
Copy Markdown
Member

Replaced prettier with oxfmt. It is compatbile with prettier format, has built-in import sorter and is much faster than prettier.

Closes #1773

@saskliutas
saskliutas requested a review from a team as a code owner August 12, 2026 13:01
Copilot AI lite review requested due to automatic review settings August 12, 2026 13:01
@saskliutas
saskliutas requested a review from a team as a code owner August 12, 2026 13:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the repo’s formatting tooling from prettier (plus @ianvs/prettier-plugin-sort-imports) to oxfmt, updating configuration and CI to use the new formatter.

Changes:

  • Replace prettier scripts/dependencies with oxfmt (format / format:fix) and update CI to run the new check.
  • Add .oxfmtrc.json to configure formatting and import sorting; remove .prettierrc and .prettierignore.
  • Regenerate pnpm-lock.yaml accordingly and apply formatting output changes in a TSX file.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Swaps formatter scripts and devDependency from prettier to oxfmt.
pnpm-lock.yaml Updates lockfile for removed prettier deps and added oxfmt (incl. platform bindings).
.oxfmtrc.json Introduces oxfmt configuration (formatting + import sorting + ignore patterns).
.github/workflows/ci.yml Replaces the “Run prettier” step with “Run oxfmt” (pnpm format).
packages/tree-widget/src/tree-widget-react/components/trees/common/UseTelemetryContext.tsx Formatting-only change consistent with formatter migration.
.prettierrc Removed in favor of .oxfmtrc.json.
.prettierignore Removed in favor of ignorePatterns in .oxfmtrc.json.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tree-Widget benchmark

Benchmark suite Current: 39abe70 Previous: 00e1622 Deviation Status
models tree creates initial filtered view for 50k target items 754 ms 783 ms -3.70% 〰️
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) 54 ms 49 ms 10.20% 〰️
models tree validates categories visibility for imodel with 50k categories 6289 ms 6439 ms -2.33% 〰️
models tree validates categories visibility for imodel with 50k categories (P95 of main thread blocks) 82 ms 83 ms -1.20% 〰️
models tree changing model visibility changes visibility for 50k elements 2406 ms 2568 ms -6.31% 〰️
models tree changing model visibility changes visibility for 50k elements (P95 of main thread blocks) 0 ms 103 ms -100%
models tree changing category visibility changes visibility for 50k elements 2472 ms 2461 ms 0.45% 〰️
models tree changing category visibility changes visibility for 50k elements (P95 of main thread blocks) 0 ms 0 ms 0% 🟰
models tree changing per-model-category override changes visibility for 50k elements 2252 ms 2423 ms -7.06% 〰️
models tree changing per-model-category override changes visibility for 50k elements (P95 of main thread blocks) 0 ms 0 ms 0% 🟰
models tree changing element visibility changes only parent nodes visibility with 50k elements 3772 ms 4034 ms -6.49% 〰️
models tree changing element visibility changes only parent nodes visibility with 50k elements (P95 of main thread blocks) 67 ms 97 ms -30.93% 〰️
categories tree creates initial filtered view for 50k items 1768 ms 1784 ms -0.90% 〰️
categories tree creates initial filtered view for 50k items (P95 of main thread blocks) 732 ms 666 ms 9.91% 〰️
categories tree changing definition container visibility changes visibility for 50k subCategories 2408 ms 2475 ms -2.71% 〰️
categories tree changing definition container visibility changes visibility for 50k subCategories (P95 of main thread blocks) 41 ms 55 ms -25.45% 〰️
categories tree changing definition container visibility changes visibility for 50k categories 4873 ms 5183 ms -5.98% 〰️
categories tree changing definition container visibility changes visibility for 50k categories (P95 of main thread blocks) 104 ms 118 ms -11.86% 〰️

This comment was automatically generated by workflow using github-action-benchmark.

@saskliutas
saskliutas requested a review from JonasDov August 12, 2026 14:42

@JonasDov JonasDov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update recommended extensions in .vscode/extensions.json? Should remove prettier extension and add the oxc extension.

Comment thread .oxfmtrc.json Outdated
@saskliutas
saskliutas merged commit 275b9e7 into master Aug 13, 2026
14 checks passed
@saskliutas
saskliutas deleted the agents/migrate-prettier-to-oxfmt-monorepo branch August 13, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use oxfmt instead of prettier

4 participants