Skip to content

imodel-browser-react: export BaseCard component - #230

Merged
ImVeryLost merged 4 commits into
mainfrom
mn/export-base-card
Aug 18, 2026
Merged

imodel-browser-react: export BaseCard component#230
ImVeryLost merged 4 commits into
mainfrom
mn/export-base-card

Conversation

@ImVeryLost

Copy link
Copy Markdown
Contributor

My project contains a grid that is for "non iTwin/iModel items". As such, i don't want to use the iModelGrid/iModelTile/etc.

But i still want to have a consistent UI across all grids, without worrying that an update to imodel-browser-react will make things look out of sync.
I would like to be able to simply use BaseCard and build the grid on top of it.

@ben-polinsky ben-polinsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, LGTM.

@ImVeryLost
ImVeryLost enabled auto-merge (squash) August 18, 2026 13:21

@alexdunae alexdunae left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern with exporting BaseCard is that it commits the admin-components package to a public API that wasn't particularly vetted.

Going through the list, though, most of the prop names are generic enough to not be controversial.

Can we rename the statusIconHref prop . (title left icon? title icon?, just icon?). UX hasn't given clear direction on what each of the customization points is meant to be used for, so calling it "status" doesn't feel accurate.

@ImVeryLost

Copy link
Copy Markdown
Contributor Author

My concern with exporting BaseCard is that it commits the admin-components package to a public API that wasn't particularly vetted.

Going through the list, though, most of the prop names are generic enough to not be controversial.

Can we rename the statusIconHref prop . (title left icon? title icon?, just icon?). UX hasn't given clear direction on what each of the customization points is meant to be used for, so calling it "status" doesn't feel accurate.

Agree that there are implications to publishing a component that was previously used internally only. Some notes:

  1. The component is already marked as alpha, and the component documentation makes it clear that it's "a building block". I hope that is enough to deter 'casual use', but I'm open to suggestions on how to update the docs to make it clearer.
  2. I'm not sure i would call it "non vetted" - it's used by the two main tiles (iModelTile and iTwinTile), which ensure that BaseCard is consistent in UI and functional.
  3. statusIconHref is already exposed in the iTwin/iModel tiles, so i would rather not rename it:
paveikslas

@ImVeryLost
ImVeryLost merged commit ae72ba7 into main Aug 18, 2026
4 checks passed
@ImVeryLost
ImVeryLost deleted the mn/export-base-card branch August 18, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants