imodel-browser-react: export BaseCard component - #230
Merged
Conversation
ImVeryLost
requested review from
alexdunae,
aruniverse,
ben-polinsky,
kckst8 and
toddsouthenbentley
as code owners
August 18, 2026 12:29
ben-polinsky
approved these changes
Aug 18, 2026
ben-polinsky
left a comment
Collaborator
There was a problem hiding this comment.
Makes sense, LGTM.
ImVeryLost
enabled auto-merge (squash)
August 18, 2026 13:21
alexdunae
requested changes
Aug 18, 2026
alexdunae
left a comment
Contributor
There was a problem hiding this comment.
My concern with exporting BaseCard is that it commits the admin-components package to a public API that wasn't particularly vetted.
Going through the list, though, most of the prop names are generic enough to not be controversial.
Can we rename the statusIconHref prop . (title left icon? title icon?, just icon?). UX hasn't given clear direction on what each of the customization points is meant to be used for, so calling it "status" doesn't feel accurate.
Contributor
Author
alexdunae
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

My project contains a grid that is for "non iTwin/iModel items". As such, i don't want to use the iModelGrid/iModelTile/etc.
But i still want to have a consistent UI across all grids, without worrying that an update to imodel-browser-react will make things look out of sync.
I would like to be able to simply use
BaseCardand build the grid on top of it.