Control sorting through props for iTwin and iModel tables - #223
Open
arome wants to merge 25 commits into
Open
Conversation
arome
marked this pull request as ready for review
July 10, 2026 18:01
arome
requested review from
alexdunae,
aruniverse,
ben-polinsky,
kckst8 and
toddsouthenbentley
as code owners
July 10, 2026 18:01
arome
changed the title
arome
enabled auto-merge (squash)
July 10, 2026 18:02
alexdunae
reviewed
Jul 10, 2026
alexdunae
reviewed
Jul 31, 2026
Co-authored-by: Alex Dunae <alex@dunae.ca>
…nents with updated view mode and action logging
…ents with new sort options handling
alexdunae
reviewed
Aug 4, 2026
…nents with controlled sort options
…ponents to use new sort options structure
…ientSideIModelSort function
…ions and onSortOptionsChange for controlled sorting
alexdunae
reviewed
Aug 7, 2026
| * Requested sort, e.g. `{ field: "displayName", direction: "asc" }`. | ||
| * `undefined` means the default server sort. | ||
| */ | ||
| sortOptions?: ITwinSortOptionsMUI; |
Contributor
There was a problem hiding this comment.
The PR title is clear that these sorting improvements only affect table view. It makes me wonder if we should be handling tile view too. $orderby is ignored for by the API for favorites/recents so we have the clientSideIModelSort. Would it make sense to add clientSideITwinSort too, for consistency?
If not, I guess we should document that this sorting does not always apply to iTwin tile view.
Contributor
Author
There was a problem hiding this comment.
Added the clientSideITwinSorting as suggested to match what we have in iModelGrid
alexdunae
reviewed
Aug 7, 2026
…IModelTableMUI.tsx Co-authored-by: Alex Dunae <alex@dunae.ca>
…TwinGrid and IModelTable interfaces
…vorites and recents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to control the sorting of the tables through props.
