Skip to content

refactor: move rpc-url input to secrets in propose-safe-multisig-tx workflow #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Le-Caignec merged 2 commits into from
Jun 24, 2026
Merged

refactor: move rpc-url input to secrets in propose-safe-multisig-tx workflow #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9bbc24
refactor: move rpc-url input to secrets in propose-safe-multisig-tx w…
Le-Caignec Jun 23, 2026
6d6c68c
refactor: update dependencies and improve transaction value validatio…
Le-Caignec Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/propose-safe-multisig-tx.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@ name: 'Propose Safe Multisig Transaction'
on:
workflow_call:
inputs:
rpc-url:
description: 'RPC URL for the blockchain network'
required: true
type: string
safe-address:
description: 'Address of the Safe contract'
required: true
Expand All @@ -29,6 +25,9 @@ on:
default: false
type: boolean
secrets:
rpc-url:
description: 'RPC URL for the blockchain network'
required: true
safe-proposer-private-key:
description: 'Private key of the proposer wallet'
required: true
Expand Down Expand Up @@ -73,7 +72,7 @@ jobs:
run: npm run propose
working-directory: ./propose-safe-multisig-tx
env:
RPC_URL: ${{ inputs.rpc-url }}
RPC_URL: ${{ secrets.rpc-url }}
SAFE_ADDRESS: ${{ inputs.safe-address }}
TRANSACTION_TO: ${{ inputs.transaction-to }}
TRANSACTION_VALUE: ${{ inputs.transaction-value }}
Expand Down
5 changes: 3 additions & 2 deletions propose-safe-multisig-tx/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ This reusable GitHub Actions workflow automates the process of proposing transac

| **Input** | **Description** | **Required** | **Default** |
| ------------------------ | ------------------------------------------------------------- | ------------ | ----------------------------------- |
| **rpc-url** | RPC URL for the blockchain network | Yes | - |
| **safe-address** | Address of the Safe contract | Yes | - |
| **transaction-to** | Target address for the transaction | Yes | - |
| **transaction-value** | Value to send in the transaction (in wei) | No | `0` |
| **transaction-data** | Transaction data/calldata | Yes | - |
| **rpc-url** | RPC URL for the blockchain network | Yes (Secret) | - |
| **safe-proposer-private-key** | Private key of the proposer wallet | Yes (Secret) | - |
| **safe-api-key** | Safe API key for transaction service | Yes (Secret) | - |

Expand All @@ -38,10 +38,10 @@ This reusable GitHub Actions workflow automates the process of proposing transac
upgrade:
uses: ./.github/workflows/propose-safe-multisig-tx.yml
secrets:
rpc-url: ${{ secrets.RPC_URL }}
safe-proposer-private-key: ${{ secrets.SAFE_PROPOSER_PRIVATE_KEY }}
safe-api-key: ${{ secrets.SAFE_API_KEY }}
with:
rpc-url: 'https://...'
safe-address: '0xab...'
transaction-to: '0xcd...'
transaction-value: '0'
Expand All @@ -50,6 +50,7 @@ This reusable GitHub Actions workflow automates the process of proposing transac

2. **Configure Secrets**
Ensure that the required secrets are added to your repository's settings:
- `RPC_URL`: The RPC URL for the blockchain network
- `SAFE_PROPOSER_PRIVATE_KEY`: The private key of the wallet that will propose the transaction
- `SAFE_API_KEY`: Your Safe API key for the transaction service

Expand Down
Loading