Fix: ConsoleLogger.warn/error swallow their second argument - #273
Merged
Conversation
adrai
added a commit
that referenced
this pull request
Jul 16, 2026
Member
|
thx, included in v1.66.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Logger interface declares warn(message, more?), and ~10 call sites pass a caught error as that second arg (e.g. logger.warn(\Plugin ${plugin.name} extractContextFromExpression
failed:
, err)inkey-finder.ts). But ConsoleLogger.warnonly forwarded the message toconsole.warn, so plugin-hook errors printed as a bare ... failed:with no detail (see screenshot). This forwards the optional second arg on bothwarnanderror, leaving single-arg output unchanged.Adds test/console-logger.test.ts. Note: 2 pre-existing failures in test/status.test.ts are unrelated (fail on main too).
Checklist
npm run testChecklist (for documentation change)