Project structure and bug fix#24
Open
Atraxus wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry @valentinstoecker for the larger rework. I tried to really make this stable for the future after I encountered a bug. Here is a summary of the changes, following online documentation:
Commit overview
76602b7 — src-layout + private
_core+ abi3 wheelssrc/rayx/, C++ tosrc/rayx_ext.cpp, one top-level CMake. [1][3]_core;__init__.pyre-exports it. Fixes the unimportable-wheel bug. [1]STABLE_ABI→ onecp312-abi3wheel; needsDevelopment.SABIModule(CMake ≥3.26) +wheel.py-api="cp312". [2][4][6]__init__.pycleanup: dynamic__all__, drop__name__hack, no leakedPath.61b7dc5 — public typing
py.typedmarker. [7]__init__.pyi(native types come from generated_core.pyi). [2][7].gitignore!__init__.pyiso the stub ships (scikit-build-core is gitignore-aware). [5]afe69fc — tests
__all__-completeness guard.test_stubs.py: fail if a helper is missing from the stub (stubtest too fragile with editable + generated stubs).Sources
[1] https://nanobind.readthedocs.io/en/latest/packaging.html
[2] https://nanobind.readthedocs.io/en/latest/api_cmake.html
[3] https://github.com/wjakob/nanobind_example
[4] https://scikit-build-core.readthedocs.io/en/latest/configuration/index.html
[5] scikit-build-core
build/_file_processor.py(each_unignored_file)[6] https://cmake.org/cmake/help/latest/module/FindPython.html
[7] https://peps.python.org/pep-0561/