chore(license) + fix(tests): finish PMPL→MPL-2.0 stragglers; repair main's test-compile breakage#65
Merged
Merged
Conversation
…re Palimpsest artifacts The PMPL-1.0-or-later -> MPL-2.0 migration landed earlier (a740439, #52); this clears the remaining stragglers, mirroring julia-the-viper's gap-006 resolution. - SPDX-License-Identifier: PMPL-1.0 -> MPL-2.0 in scorecard.yml + secret-scanner.yml (codeql.yml + the README badge were already done on main). - threat-model.a2ml: drop the "until PMPL is formally recognised" note (PMPL retired). - Retire stale Palimpsest artifacts: PALIMPSEST.adoc (still claimed PMPL-1.0, contradicting the completed migration), LICENSE.txt (old PMPL license text; canonical LICENSE is already MPL-2.0), LICENSES/PMPL-1.0-or-later.txt (unused now that no file declares PMPL). Canonical LICENSE (MPL-2.0) unchanged. Remaining minor follow-ups (NOTICE prose, a k9 setup-example, guix/flake license fields) noted for a later pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BJmfoz1ZS1Pejy9LLMY742
main's "remediate UnboundedAllocation" commit mechanically rewrote fs::read_to_string(PATH) into a bounded File::open(...).take(...).read_to_string() form, but for multi-.join(...) paths it glued `.and_then` onto the path's join instead of File::open and stranded a paren -- leaving 9 test sites that don't compile (mismatched/unexpected closing delimiter). This reddened ALL januskey CI (Rust Build + Unit Tests, E2E), #65 included. Repairs the 9 sites in aspect_test / p2p_test / concurrency_test / e2e_test: close File::open(FULL_PATH) before .and_then(...), drop the stray paren. Kept the bounded-read form (respects the remediation's intent); cargo fmt normalized the expressions. cargo test --workspace green (all suites pass). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BJmfoz1ZS1Pejy9LLMY742
hyperpolymath
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things (the test fix was folded in here because the one-branch-per-repo rule means it shares this branch — and because #65 couldn't go green without it).
1. License — finish the PMPL-1.0 → MPL-2.0 stragglers
The migration mostly landed earlier (
a740439, #52); this clears the remnants, mirroringjulia-the-viper's gap-006:PMPL-1.0 → MPL-2.0inscorecard.yml+secret-scanner.yml(codeql + README badge already done onmain).threat-model.a2ml: dropped the "fallback until PMPL is recognised" note.PALIMPSEST.adoc(still claimed PMPL-1.0),LICENSE.txt(old PMPL text; canonicalLICENSEis MPL-2.0),LICENSES/PMPL-1.0-or-later.txt. No file declaresSPDX … PMPLanymore.2. Tests — repair a pre-existing compile breakage on
mainNot caused by the license change.
main's "remediate UnboundedAllocation" commit mechanically rewrotefs::read_to_string(PATH)into a boundedFile::open(...).take(...).read_to_string()form, but for multi-.join(...)paths it glued.and_thenonto the path's.join(...)instead ofFile::open(...)and stranded a paren — leaving 9 sites that don't compile (mismatched/unexpected closing delimiter) inaspect_test/p2p_test/concurrency_test/e2e_test. That reddened all januskey CI (Rust Build + Unit Tests, E2E), not just this PR.Fixed all 9: close
File::open(FULL_PATH)before.and_then(...), drop the stray paren; kept the bounded-read form (respects the remediation's intent);cargo fmtnormalized them.cargo test --workspaceis fully green (all suites pass).🤖 Generated with Claude Code
https://claude.ai/code/session_01BJmfoz1ZS1Pejy9LLMY742