feat(deps-viewer): mark alloc tasks as fire sources#1349
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated dependency graph marker computation so ChangesAlloc Fire Marker Rendering
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the dependency viewer to treat 'alloc' tasks as fire-marked ('🔥') producers by default, which also propagates star-markers ('⭐') to their successors. The reviewer identified an issue where, in plain mode (when task_table is empty or None), all nodes default to being classified as 'alloc' tasks. This leads to excessive visual noise as every node becomes fire-marked. The reviewer suggested guarding _fire_marked to return False when task_table is empty and updating the unit tests accordingly.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
🔥by default⭐computation, so consumers fully fed by alloc and/or flagged producers are shown consistentlyValidation
deps.jsonruff check simpler_setup/tools/deps_viewer.py tests/ut/py/test_deps_viewer.py