Skip to content

feat(deps-viewer): mark alloc tasks as fire sources#1349

Open
Little-oil wants to merge 2 commits into
hw-native-sys:mainfrom
Little-oil:codex/deps-viewer-alloc-fire
Open

feat(deps-viewer): mark alloc tasks as fire sources#1349
Little-oil wants to merge 2 commits into
hw-native-sys:mainfrom
Little-oil:codex/deps-viewer-alloc-fire

Conversation

@Little-oil

Copy link
Copy Markdown

Summary

Validation

  • direct deps_viewer marker assertions against Qwen3 decode deps.json
  • ruff check simpler_setup/tools/deps_viewer.py tests/ut/py/test_deps_viewer.py

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ed816e7b-7336-43bb-b0b8-463eac9c8441

📥 Commits

Reviewing files that changed from the base of the PR and between 438d5cb and 431768f.

📒 Files selected for processing (2)
  • simpler_setup/tools/deps_viewer.py
  • tests/ut/py/test_deps_viewer.py

📝 Walkthrough

Walkthrough

Updated dependency graph marker computation so alloc tasks receive the fire marker, with metadata passed through emit_dot. Tests now verify fire-marked alloc sources and star-marked successor nodes.

Changes

Alloc Fire Marker Rendering

Layer / File(s) Summary
Marker logic and rendering validation
simpler_setup/tools/deps_viewer.py, tests/ut/py/test_deps_viewer.py
_task_markers recognizes alloc tasks as fire-marked, emit_dot passes metadata, and tests verify the resulting fire and star labels.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

I’m a bunny with sparks in my nest,
Alloc tasks now glow with the best.
Fire leads the way,
Stars follow the array—
DOT graphs look bright and refreshed!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: treating alloc tasks as fire sources in deps-viewer.
Description check ✅ Passed The description accurately matches the implemented deps-viewer badge and test updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dependency viewer to treat 'alloc' tasks as fire-marked ('🔥') producers by default, which also propagates star-markers ('⭐') to their successors. The reviewer identified an issue where, in plain mode (when task_table is empty or None), all nodes default to being classified as 'alloc' tasks. This leads to excessive visual noise as every node becomes fire-marked. The reviewer suggested guarding _fire_marked to return False when task_table is empty and updating the unit tests accordingly.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread simpler_setup/tools/deps_viewer.py Outdated
Comment thread tests/ut/py/test_deps_viewer.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant