Add conc.include.end option to exclude interval end point#571
Open
Gero1999 wants to merge 4 commits into
Open
Conversation
this prevents problems specially with multiple-dose bolus administrations, where the next profile's C0 point, if present, can affect the previous profile calculations. An example:
```r
my.conc <- PKNCAconc(d.conc, conc ~ time | subject)
my.dose <- PKNCAdose(d.dose, dose ~ time | subject, route = "intravascular")
my.data <- PKNCAdata(my.conc, my.dose,
intervals = data.frame(start = 0, end = 24, tmax = TRUE))
res <- as.data.frame(pk.nca(my.data))
res[res$PPTESTCD == "tmax", c("start", "end", "PPTESTCD", "PPORRES")]
#> start end PPTESTCD PPORRES
#> 1 0 24 tmax 24.0 <- should be 0
```
Gero1999
changed the title
Gero1999
marked this pull request as ready for review
July 24, 2026 13:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a global
conc.include.endoption (defaultTRUE) controlling whether a concentration measured exactly attime == endis included in an interval's calculations. Set it toFALSEfor half-open intervals[start, end).Useful when a point at the interval boundary belongs to the next dose (e.g. an imputed C0) and wrongly inflates AUC/tmax for the current profile.
The internal
filter_interval()already supportedinclude_end(dose selection usesinclude_end = FALSE); this exposes it for concentrations via the options system.R/PKNCA.options.R: registerconc.include.end(logical, validated)R/pk.calc.all.R: pass the option through at the concentration call siteDefault preserves existing behavior.