fix(perplexity): use all_special_tokens for GPT-2 tokenizer compatibility - #789
Open
akaashsa wants to merge 1 commit into
Open
fix(perplexity): use all_special_tokens for GPT-2 tokenizer compatibility#789akaashsa wants to merge 1 commit into
akaashsa wants to merge 1 commit into
Conversation
…lity GPT-2's slow tokenizer (GPT2Tokenizer) does not expose special_tokens_map_extended, causing an AttributeError when computing perplexity with batch_size > 1. Additionally, the pad_token guard was conditioned on batch_size > 1, but the tokenizer is always called with padding=True, meaning pad_token is required even for batch_size=1 when multiple predictions are passed. Fix: - Replace special_tokens_map_extended.values() with all_special_tokens, which is defined on PreTrainedTokenizerBase and returns a flat list of strings for both slow and fast tokenizers. - Remove the batch_size > 1 condition so pad_token is set whenever it is missing, matching the actual padding requirement. Fixes huggingface#766
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPT-2's slow tokenizer (GPT2Tokenizer) does not expose special_tokens_map_extended, causing an AttributeError when computing perplexity with batch_size > 1.
Additionally, the pad_token guard was conditioned on batch_size > 1, but the tokenizer is always called with padding=True, meaning pad_token is required even for batch_size=1 when multiple predictions are passed.
Fix:
Fixes #766