Fix attention backend leaking across models - #14335
Open
raghulchandramouli wants to merge 2 commits into
Open
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Author
|
hello @DN6 both of these issues being raised are not becuz of me, its an Anima mismatch error which was never touched by me |
Author
|
Hi @DN6, I updated this PR to the latest
This PR does not modify MiniMax-H3 or modular pipeline code. GitHub does not Could you please rerun the failed jobs, or advise whether the MiniMax-H3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In a nutshell, It Prevents
ModelMixin.set_attention_backend()from changing the process-global active attention backend. The method now only configures attention processors belonging to the target model.Self-review:
Ran self-review and these are the validation I got from it:
Test I Ran:
make style: passedmake fix-copies: passedgit diff --check: passedTest I wrote:
tests/attention.pyto make sure thatModelMixin.set_attention_backend()does not modify the registry.discussion
This appears as an issue raised by sayak Paul - #14249
Fixes #14249
Before submitting
self-reviewskill on the diff?documentation guidelines, and
here are tips on formatting docstrings.
It would be great if @qgallouedec or @sayakpaul can you take a quick review of this PR??