Skip to content

Fix test_lazy_choices_help failure in Python 3.14 #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vinayK34 wants to merge 1 commit into from
Closed

Fix test_lazy_choices_help failure in Python 3.14 #1922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions httpie/cli/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,13 @@ def load(self) -> T:

@property
def help(self) -> str:
# Avoid calling getter during parser initialization in Python 3.14+
# Only format help when it's actually needed (not during parser init)
if self._help is None and self.help_formatter is not None:
self._help = self.help_formatter(
self.load(),
isolation_mode=self.isolation_mode
)
return self._help
# During parser initialization, we don't want to call the getter yet
# Return a placeholder to satisfy argparse requirements
self._help = ""
return self._help if self._help is not None else ""

@help.setter
def help(self, value: Any) -> None:
Expand All @@ -76,4 +77,4 @@ def __iter__(self) -> Iterator[T]:
return iter(self.load())

def __call__(self, parser, namespace, values, option_string=None):
setattr(namespace, self.dest, values)
setattr(namespace, self.dest, values)
Loading