Feat/canvas trackpad navigation - #13
Open
cododel wants to merge 5 commits into
Open
Conversation
- add configurable wheel ownership and full navigation overrides - preserve Browser gestures across native view boundaries - document focus, migration, and native sink decisions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds intent-aware canvas navigation for trackpads and mouse wheels without attempting to identify the physical input device.
Cmd/Ctrl+scrollperform focal-point zoom.Off / On / Key.Widget focus and input ownership
Input ownership is based on logical widget focus rather than device heuristics.
grab/grabbingcursor.Command/Ctrlbindings remain compatible with ordinary application shortcuts.DOM widgets, xterm surfaces, plugin iframes, and native Browser surfaces follow the same shared ownership policy where their platform constraints allow it.
Native Browser continuity
Electron routes input directly to child
WebContentsViewsurfaces, which can interrupt a wheel sequence when the pointer crosses the native Browser boundary.The Browser integration therefore:
pageorcanvasownership once at sequence start;Cmd/Ctrl+scrollto canvas zoom;This preserves Browser-to-canvas and canvas-to-Browser gesture continuity without trackpad detection or Chromium patches.
Settings migration
Commandon macOS andCtrlelsewhere.zoomOverApplicationsvalues preserve their meaning.Architecture
Canvas input orchestration is isolated from large UI and Browser service components:
Verification
Windows Precision Touchpad and Linux/libinput manual matrices remain recommended before release.