Check the CI gate against check-runs, not the legacy status API - #8
Merged
Conversation
The release checklist's CI gate reads `commits/<sha>/status`, which reports the legacy commit Status API. This repo publishes GitHub Checks and records no legacy statuses, so that endpoint answers `pending` no matter what — it reported `pending` for v0.1.2 while all six checks were green. A gate that is permanently red is worse than no gate: it either blocks every release or teaches you to ignore it. Asking for check-runs answers the question actually being asked. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hit while cutting v0.1.2.
The release skill's CI gate runs:
gh api "repos/hookdeck/hermes-hookdeck/commits/$(git rev-parse origin/main)/status" --jq .stateThat endpoint reports the legacy commit Status API. This repo publishes GitHub Checks and records no legacy statuses, so it answers
pendingregardless of the actual result — with zero statuses,pendingis the default. It reportedpendingfor the v0.1.2 release commit while all six checks werecompleted/success.A gate that is permanently red either blocks every release or trains you to wave it through. Swapped for
check-runs, which answers the question being asked, plus a note on why so nobody swaps it back.Not packaged —
skills/at the repo root is outsidehookdeck/, so this ships nothing and needs no release.