日付あり・未スケジュール間の移動でQuery cacheを楽観的更新する - #279
Merged
Merged
Conversation
10 tasks
|
🚀 プレビュー環境がデプロイされました! URL: https://tascal-pr-279-197260822086.asia-northeast1.run.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #277
概要
Webでタスクを日付あり・未スケジュール間に移動した際、表示中カレンダー範囲と未スケジュール一覧のTanStack Query cacheを同時に楽観的更新するようにしました。
onMutate内部例外でも部分更新を復元し、lockとcoordinatorを確実に解放undefined状態を復元影響範囲
apps/web/src/hooks/useTasks.tsapps/web/src/hooks/useTasks.test.tsxAPI、DB、CLI、Mobileには変更を加えていません。
テスト
pnpm --filter @tascal/web exec vitest run src/hooks/useTasks.test.tsx(16 tests)pnpm lintpnpm format:checkpnpm typecheckpnpm test(Web 102、API 102、CLI 33、Shared 21、Mobile 24、Design tokens 2)Cross-review
onErrorのrestore例外・invalidate失敗・冪等解放に対する追加テスト余地の指摘onMutate部分更新例外、rollback、同一ID後続回復、invalidateを自動テスト済みのため見送り